Skip to content

chore: add swiftformat GH action #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 23, 2025
Merged

chore: add swiftformat GH action #3732

merged 15 commits into from
Sep 23, 2025

Conversation

phantumcode
Copy link
Contributor

@phantumcode phantumcode commented May 31, 2024 •
edited by thisisabhash
Loading

Issue #

None

Description

Adds Swiftformat Github action for pull requests

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode changed the title chore: add swiftformat GH action [DRAFT] chore: add swiftformat GH action May 31, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.14%. Comparing base (acdd2dc) to head (b113a0a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...gin/Support/Helpers/PreferredChallengeHelper.swift 0.00% 2 Missing ⚠️
...sPlugin/Liveness/Service/FaceLivenessSession.swift 0.00% 2 Missing ⚠️
...hPlugin/Actions/SignIn/VerifySignInChallenge.swift 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3732      +/-   ##
==========================================
+ Coverage   67.81%   68.14%   +0.32%     
==========================================
  Files        1129     1129              
  Lines       52472    54486    +2014     
==========================================
+ Hits        35585    37129    +1544     
- Misses      16887    17357     +470
Flag Coverage Δ
API_plugin_unit_test 70.15% <100.00%> (-0.19%) ⬇️
AWSPluginsCore 69.50% <ø> (+0.25%) ⬆️
Amplify 47.87% <ø> (-0.06%) ⬇️
Analytics_plugin_unit_test 85.59% <ø> (+0.38%) ⬆️
Auth_plugin_unit_test 73.61% <81.25%> (-0.19%) ⬇️
DataStore_plugin_unit_test 84.43% <100.00%> (+0.99%) ⬆️
Geo_plugin_unit_test 75.95% <ø> (+1.08%) ⬆️
Logging_plugin_unit_test 65.56% <100.00%> (+0.50%) ⬆️
Predictions_plugin_unit_test 34.63% <0.00%> (-0.14%) ⬇️
PushNotifications_plugin_unit_test 88.76% <ø> (+0.32%) ⬆️
Storage_plugin_unit_test 78.90% <100.00%> (-0.09%) ⬇️
unit_tests 68.14% <83.33%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

@github-actions GitHub Actions
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

@phantumcode phantumcode marked this pull request as ready for review October 24, 2024 19:17
@phantumcode phantumcode requested a review from a team as a code owner October 24, 2024 19:17
@phantumcode phantumcode changed the title [DRAFT] chore: add swiftformat GH action chore: add swiftformat GH action Oct 24, 2024
@thisisabhash
Copy link
Member

thisisabhash commented Sep 22, 2025 •
edited
Loading

these cases were duplicated mistakenly in last PR merge to main:

case .signingInWithUserAuth(let signInEventData):
case .signingInWithWebAuthn(let webAuthnState):
case .autoSigningIn:

@harsh62 harsh62 merged commit 68dda60 into main Sep 23, 2025
96 checks passed
@harsh62 harsh62 deleted the chore/add_swiftformat branch September 23, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsh62 harsh62 harsh62 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phantumcode @thisisabhash @harsh62