feat: add support for ReturnValuesOnConditionCheckFailure in Idempotency #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng record details and improve error handling in persistence layer
pull-request-size
bot
added
the
size/L
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #930 +/- ##
===========================================
+ Coverage 77.28% 77.31% +0.03%
===========================================
Files 272 272
Lines 10875 10899 +24
Branches 1278 1281 +3
===========================================
+ Hits 8405 8427 +22
- Misses 2054 2055 +1
- Partials 416 417 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey Henrique, I'll review this tomorrow - thanks for working on this! |
dreamorosi
approved these changes
Jul 18, 2025
libraries/src/AWS.Lambda.Powertools.Idempotency/Persistence/BasePersistenceStore.cs
Outdated
Show resolved
Hide resolved
…xistingRecord method
…xistingRecord tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #803
Summary
Changes
This pull request enhances the idempotency handling in the AWS Lambda Powertools library by introducing new functionality for processing existing records and improving exception handling. The changes include updates to the
IdempotencyItemAlreadyExistsExceptionclass, modifications to the persistence layer for better validation and caching, and the addition of comprehensive tests to ensure correctness.Enhancements to idempotency handling:
Improved exception handling in
IdempotencyItemAlreadyExistsException:Recordproperty to store the existing record details when an exception is thrown.DynamoDBPersistenceStoreto populate theRecordproperty in the exception when a conditional check fails, enabling downstream validation and caching.New method for processing existing records in
BasePersistenceStore:ProcessExistingRecordto validate an existing record against the current data payload and optionally cache it locally. This ensures data consistency and improves performance when local caching is enabled.IdempotencyAspectHandlerto utilize theProcessExistingRecordmethod for handling exceptions more effectively.User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.