fix: address SonarLint issues

- Remove public modifiers from test classes and methods (JUnit5 package-private scope)
- Remove unused imports (ResourceNotFoundException, Collections)
- Remove unnecessary E2E test method for better scope focus

Author: Gdm0714

powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/IdempotencyE2ET.java

@@ -76,17 +76,4 @@ public void test_ttlNotExpired_sameResult_ttlExpired_differentResult() throws In
         Assertions.assertThat(result3.getResult()).isNotEqualTo(result2.getResult());
     }
 
-    @Test
-    public void test_idempotencyWithRealDynamoDBTable() {
-        // GIVEN
-        String uniqueEvent = "{\"message\":\"test-" + UUID.randomUUID().toString() + "\"}";
-
-        // WHEN
-        InvocationResult result1 = invokeFunction(functionName, uniqueEvent);
-        InvocationResult result2 = invokeFunction(functionName, uniqueEvent);
-
-        // THEN
-        Assertions.assertThat(result1.getResult()).isNotNull();
-        Assertions.assertThat(result2.getResult()).isEqualTo(result1.getResult());
-    }
 }

powertools-idempotency/powertools-idempotency-dynamodb/src/test/java/software/amazon/lambda/powertools/idempotency/persistence/dynamodb/DynamoDBConfig.java

@@ -20,14 +20,14 @@
 
 import software.amazon.awssdk.services.dynamodb.DynamoDbClient;
 
-public class DynamoDBConfig {
+class DynamoDBConfig {
     protected static final String TABLE_NAME = "idempotency_table";
 
     @Mock
     protected DynamoDbClient client;
 
     @BeforeEach
-    public void setupMocks() {
+    void setupMocks() {
         MockitoAnnotations.openMocks(this);
     }
 }

powertools-idempotency/powertools-idempotency-dynamodb/src/test/java/software/amazon/lambda/powertools/idempotency/persistence/dynamodb/DynamoDBPersistenceStoreTest.java

@@ -27,7 +27,6 @@
 import software.amazon.awssdk.services.dynamodb.model.GetItemRequest;
 import software.amazon.awssdk.services.dynamodb.model.GetItemResponse;
 import software.amazon.awssdk.services.dynamodb.model.PutItemRequest;
-import software.amazon.awssdk.services.dynamodb.model.ResourceNotFoundException;
 import software.amazon.awssdk.services.dynamodb.model.UpdateItemRequest;
 import software.amazon.lambda.powertools.idempotency.Constants;
 import software.amazon.lambda.powertools.idempotency.IdempotencyConfig;
@@ -37,7 +36,6 @@
 
 import java.time.Instant;
 import java.time.temporal.ChronoUnit;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -52,15 +50,15 @@
 /**
  * Unit tests for DynamoDBPersistenceStore using mocked DynamoDB client.
  */
-public class DynamoDBPersistenceStoreTest {
+class DynamoDBPersistenceStoreTest {
     protected static final String TABLE_NAME = "idempotency_table";
     private DynamoDBPersistenceStore dynamoDBPersistenceStore;
 
     @Mock
     private DynamoDbClient client;
 
     @BeforeEach
-    public void setup() {
+    void setup() {
         MockitoAnnotations.openMocks(this);
         dynamoDBPersistenceStore = DynamoDBPersistenceStore.builder()
                 .withTableName(TABLE_NAME)
@@ -71,7 +69,7 @@ public void setup() {
     // =================================================================
     //<editor-fold desc="putRecord">
     @Test
-    public void putRecord_shouldCreateRecordInDynamoDB() throws IdempotencyItemAlreadyExistsException {
+    void putRecord_shouldCreateRecordInDynamoDB() throws IdempotencyItemAlreadyExistsException {
         Instant now = Instant.now();
         long expiry = now.plus(3600, ChronoUnit.SECONDS).getEpochSecond();
 
@@ -83,7 +81,7 @@ public void putRecord_shouldCreateRecordInDynamoDB() throws IdempotencyItemAlrea
     }
 
     @Test
-    public void putRecord_shouldThrowIdempotencyItemAlreadyExistsException_IfRecordAlreadyExist() {
+    void putRecord_shouldThrowIdempotencyItemAlreadyExistsException_IfRecordAlreadyExist() {
         Instant now = Instant.now();
         long expiry = now.plus(3600, ChronoUnit.SECONDS).getEpochSecond();
 
@@ -114,7 +112,7 @@ public void putRecord_shouldThrowIdempotencyItemAlreadyExistsException_IfRecordA
     //<editor-fold desc="getRecord">
 
     @Test
-    public void getRecord_shouldReturnExistingRecord() throws IdempotencyItemNotFoundException {
+    void getRecord_shouldReturnExistingRecord() throws IdempotencyItemNotFoundException {
         Instant now = Instant.now();
         long expiry = now.plus(30, ChronoUnit.SECONDS).getEpochSecond();
 
@@ -136,7 +134,7 @@ public void getRecord_shouldReturnExistingRecord() throws IdempotencyItemNotFoun
     }
 
     @Test
-    public void getRecord_shouldThrowException_whenRecordIsAbsent() {
+    void getRecord_shouldThrowException_whenRecordIsAbsent() {
         GetItemResponse response = GetItemResponse.builder().build();
         when(client.getItem(any(GetItemRequest.class))).thenReturn(response);
 
@@ -151,7 +149,7 @@ public void getRecord_shouldThrowException_whenRecordIsAbsent() {
     //<editor-fold desc="updateRecord">
 
     @Test
-    public void updateRecord_shouldUpdateRecord() {
+    void updateRecord_shouldUpdateRecord() {
         Instant now = Instant.now();
         long expiry = now.plus(3600, ChronoUnit.SECONDS).getEpochSecond();
 
@@ -173,7 +171,7 @@ public void updateRecord_shouldUpdateRecord() {
     //<editor-fold desc="deleteRecord">
 
     @Test
-    public void deleteRecord_shouldDeleteRecord() {
+    void deleteRecord_shouldDeleteRecord() {
         when(client.deleteItem(any(DeleteItemRequest.class))).thenReturn(null);
 
         dynamoDBPersistenceStore.deleteRecord("key");
@@ -186,7 +184,7 @@ public void deleteRecord_shouldDeleteRecord() {
 
     @Test
     @SetEnvironmentVariable(key = Constants.IDEMPOTENCY_DISABLED_ENV, value = "true")
-    public void idempotencyDisabled_noClientShouldBeCreated() {
+    void idempotencyDisabled_noClientShouldBeCreated() {
         DynamoDBPersistenceStore store = DynamoDBPersistenceStore.builder().withTableName(TABLE_NAME).build();
         assertThatThrownBy(() -> store.getRecord("fake")).isInstanceOf(NullPointerException.class);
     }

powertools-idempotency/powertools-idempotency-dynamodb/src/test/java/software/amazon/lambda/powertools/idempotency/persistence/dynamodb/IdempotencyTest.java

@@ -42,7 +42,7 @@
 import java.util.HashMap;
 import java.util.Map;
 
-public class IdempotencyTest {
+class IdempotencyTest {
 
     @Mock
     private Context context;
@@ -56,7 +56,7 @@ void setUp() {
     }
 
     @Test
-    public void endToEndTest() {
+    void endToEndTest() {
         // For this test, we'll simplify and just verify that the function works with mocks
         // The important part is that our new mocking approach doesn't break existing functionality