Eventbridge api destination with cmk #2806
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parikhudit
reviewed
Sep 20, 2025
There was a problem hiding this comment.
Can you please rename the file to README.md?
parikhudit
reviewed
Sep 20, 2025
| @@ -0,0 +1,80 @@ | |||
| # EventBridge API Destinations with OAuth and CMK Encryption | |||
parikhudit
reviewed
Sep 20, 2025
Comment on lines
+28
to
+30
| * Also, run the below CloudFormation (CFN) command to create pre-requisit resources: | ||
| ```bash | ||
| aws cloudformation create-stack --stack-name serverlessland-prerequisite --template-body file://prerequsite.yaml |
parikhudit
reviewed
Sep 20, 2025
There was a problem hiding this comment.
typo: prerequisite.yaml
|
Can you please update the folder structure to have a single parent folder named with pattern-name? |
parikhudit
reviewed
Sep 20, 2025
| IsValueSecret: true | ||
| DependsOn: ConnectionSecret | ||
|
|
||
| # Api Destination Resource |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Eventbridge api destination with CMK serverless pattern added, which is based on the recent aws announcement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.