Skip to content

Commit 3e08736

Browse files
committed
fix empty strings as null AttributeValue issue
1 parent 36d9cc3 commit 3e08736

File tree

3 files changed

+23
-2
lines changed

3 files changed

+23
-2
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"Projects": [
3+
{
4+
"Name": "Amazon.Lambda.DynamoDBEvents.SDK.Convertor",
5+
"Type": "Patch",
6+
"ChangelogMessages": [
7+
"Fix Empty Strings converted to null issue."
8+
]
9+
}
10+
]
11+
}

Libraries/src/Amazon.Lambda.DynamoDBEvents.SDK.Convertor/DynamodbAttributeValueConvertor.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public static Amazon.DynamoDBv2.Model.AttributeValue ConvertToSdkAttribute(this
2121
var sdkAttribute = new Amazon.DynamoDBv2.Model.AttributeValue();
2222

2323
// String
24-
if (!string.IsNullOrEmpty(lambdaAttribute.S))
24+
if (lambdaAttribute.S!=null)
2525
sdkAttribute.S = lambdaAttribute.S;
2626

2727
// Number
@@ -112,7 +112,7 @@ public static Amazon.DynamoDBStreams.Model.AttributeValue ConvertToSdkStreamAttr
112112
var sdkAttribute = new Amazon.DynamoDBStreams.Model.AttributeValue();
113113

114114
// String
115-
if (!string.IsNullOrEmpty(lambdaAttribute.S))
115+
if (lambdaAttribute.S != null)
116116
sdkAttribute.S = lambdaAttribute.S;
117117

118118
// Number

Libraries/test/Amazon.Lambda.DynamoDBEvents.SDK.Convertor.Tests/DynamodbAttributeValueConvertorTests.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,16 @@ public void ConvertToSdkAttribute_StringValue_ReturnsSdkAttribute()
1212
Assert.Equal("TestString", sdkAttribute.S);
1313
}
1414

15+
[Fact]
16+
public void ConvertToSdkAttribute_EmptyStringValue_ReturnsSdkAttribute()
17+
{
18+
var lambdaAttribute = new DynamoDBEvent.AttributeValue { S = string.Empty };
19+
var sdkAttribute = lambdaAttribute.ConvertToSdkAttribute();
20+
21+
Assert.NotNull(sdkAttribute);
22+
Assert.Equal(string.Empty, sdkAttribute.S);
23+
}
24+
1525
[Fact]
1626
public void ConvertToSdkAttribute_NumberValue_ReturnsSdkAttribute()
1727
{

0 commit comments

Comments
 (0)