-
Notifications
You must be signed in to change notification settings - Fork 1k
Description
Describe the bug
We have noticed three instances of incorrect helming in some of your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from aquasecurity/trivy-operator#729 regarding the incorrect helming defect.
initContainers.pullPolicy does not take effect when changed to a value other than default value 'IfNotPresent'. This is due to missing implementation for this value in appmesh-spire-agent/templates/deployment.yaml file:
eks-charts/stable/appmesh-spire-agent/templates/deployment.yaml
Lines 23 to 27 in e71a947
| initContainers: | |
| - name: init | |
| image: "{{ .Values.initContainers.image }}" | |
| args: | |
| - -t |
init.image.pullPolicy, and nodeAgent.image.pullPolicy does not take effect when changed to a value other than default value 'Always'. This is due to missing implementation for this value in aws-vpc-cni/templates/daemonset.yaml file:
eks-charts/stable/aws-vpc-cni/templates/daemonset.yaml
Lines 41 to 43 in e431463
| initContainers: | |
| - name: aws-vpc-cni-init | |
| image: {{ include "aws-vpc-cni.initImage" . }} |
eks-charts/stable/aws-vpc-cni/templates/daemonset.yaml
Lines 124 to 125 in e431463
| - name: aws-eks-nodeagent | |
| image: {{ include "aws-vpc-cni.nodeAgentImage" . }} |
Steps to reproduce
modify these values in values.yaml file, then deploy them.
Expected outcome
The changes for image pull policy should be respected.
Environment
- Chart name: appmesh-spire-agent, and 12597f/stable/aws-vpc-cni
- Chart version: main version
- Kubernetes version:
- Using EKS (yes/no), if so version?
Additional Context: