Skip to content

Commit de7b926

Browse files
authored
Fix typescript build lib target (#715)
* chore(dep): run npm audit fix. * fix(tsc): error in type definition. * chore(dep): rollback npm audit breaking webpack.
1 parent 01964d3 commit de7b926

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/graph_notebook/widgets/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"source-map-loader": "0.2.4",
5454
"style-loader": "1.2.1",
5555
"ts-loader": "5.4.5",
56-
"typescript": "4.1.6",
56+
"typescript": "5.6.3",
5757
"webpack": "4.43.0",
5858
"webpack-cli": "3.3.11",
5959
"webpack-dev-server": "3.11.0"

src/graph_notebook/widgets/src/types.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export class VisNode implements Node, DynamicObject {
3434

3535
[key: string]: any;
3636

37-
constructor(readonly id: string) {
37+
constructor(id: string) {
3838
this.id = id;
3939
}
4040

@@ -88,9 +88,9 @@ export class VisEdge implements Edge {
8888
[key: string]: any;
8989

9090
constructor(
91-
readonly from: string,
92-
readonly to: string,
93-
readonly id: string,
91+
from: string,
92+
to: string,
93+
id: string,
9494
label: string
9595
) {
9696
this.from = from;
@@ -184,7 +184,7 @@ export class IdentifiableDynamicObject extends DynamicObject {
184184

185185
[key: string]: any;
186186

187-
constructor(readonly id: string) {
187+
constructor(id: string) {
188188
super();
189189
this.id = id;
190190
}

0 commit comments

Comments
 (0)