Skip to content

Commit e7f8b96

Browse files
committed
refactor: convert ConnectorResourceReference from namedtuple to dataclass
1 parent b0231f5 commit e7f8b96

File tree

1 file changed

+13
-15
lines changed

1 file changed

+13
-15
lines changed

samtranslator/model/connector/connector.py

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from collections import namedtuple
1+
from dataclasses import dataclass
22
from typing import Any, Dict, Iterable, List, Optional
33

44
from typing_extensions import TypeGuard
@@ -16,20 +16,18 @@
1616
from samtranslator.public.sdk.resource import SamResourceType
1717
from samtranslator.utils.utils import as_array, insert_unique
1818

19-
# TODO: Switch to dataclass
20-
ConnectorResourceReference = namedtuple(
21-
"ConnectorResourceReference",
22-
[
23-
"logical_id",
24-
"resource_type",
25-
"arn",
26-
"role_name",
27-
"queue_url",
28-
"resource_id",
29-
"name",
30-
"qualifier",
31-
],
32-
)
19+
@dataclass(frozen=True)
20+
class ConnectorResourceReference:
21+
"""Reference to a connector resource with all its identifying properties."""
22+
23+
logical_id: str
24+
resource_type: str
25+
arn: Optional[str] = None
26+
role_name: Optional[str] = None
27+
queue_url: Optional[str] = None
28+
resource_id: Optional[str] = None
29+
name: Optional[str] = None
30+
qualifier: Optional[str] = None
3331

3432
_SAM_TO_CFN_RESOURCE_TYPE = {
3533
SamResourceType.Function.value: LambdaFunction.resource_type,

0 commit comments

Comments
 (0)