Skip to content

Commit f5bbc43

Browse files
cpyle0819Laren-AWS
cpyle0819
authored and
Laren-AWS
committed
JavaScript (v3): Unit tests - Fix incorrect link in S3 unit tests comments.
1 parent 43c22bb commit f5bbc43

20 files changed

+76
-76
lines changed

‎javascriptv3/example_code/s3/tests/copy-object.unit.test.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ describe("copy-object", () => {
3838

3939
it("should log a relevant error message if the object is in an archive tier", async () => {
4040
const error = new ObjectNotInActiveTierError();
41-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
42-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
41+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
42+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
4343
send.mockRejectedValue(error);
4444

4545
const spy = vi.spyOn(console, "error");

‎javascriptv3/example_code/s3/tests/create-bucket.unit.test.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ describe("create-bucket", () => {
3434

3535
it("should log a relevant error message if a bucket already exists globally", async () => {
3636
const error = new BucketAlreadyExists();
37-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
38-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
37+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
38+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
3939
send.mockRejectedValue(error);
4040

4141
const spy = vi.spyOn(console, "error");
@@ -49,8 +49,8 @@ describe("create-bucket", () => {
4949

5050
it("should log a relevant error message if a bucket already exists in the users AWS account", async () => {
5151
const error = new BucketAlreadyOwnedByYou();
52-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
53-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
52+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
53+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
5454
send.mockRejectedValue(error);
5555

5656
const spy = vi.spyOn(console, "error");

‎javascriptv3/example_code/s3/tests/delete-bucket-policy.unit.test.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ describe("delete-bucket-policy", () => {
3333

3434
it("should log a relevant error when the bucket doesn't exist", async () => {
3535
const error = new S3ServiceException("The specified bucket does not exist");
36-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
37-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
36+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
37+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
3838
error.name = "NoSuchBucket";
3939
const bucketName = "amzn-s3-demo-bucket";
4040
send.mockRejectedValueOnce(error);
@@ -50,8 +50,8 @@ describe("delete-bucket-policy", () => {
5050

5151
it("should indicate a failure came from S3 when the error isn't generic", async () => {
5252
const error = new S3ServiceException("Some S3 service exception.");
53-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
54-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
53+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
54+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
5555
error.name = "ServiceException";
5656
const bucketName = "amzn-s3-demo-bucket";
5757
send.mockRejectedValueOnce(error);

‎javascriptv3/example_code/s3/tests/delete-bucket-website.unit.test.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ const { main } = await import("../actions/delete-bucket-website.js");
2121
describe("delete-bucket-website", () => {
2222
it("should log a relevant error when the bucket doesn't exist", async () => {
2323
const error = new S3ServiceException("The specified bucket does not exist");
24-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
25-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
24+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
25+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
2626
error.name = "NoSuchBucket";
2727
const bucketName = "amzn-s3-demo-bucket";
2828
send.mockRejectedValueOnce(error);
@@ -38,8 +38,8 @@ describe("delete-bucket-website", () => {
3838

3939
it("should indicate a failure came from S3 when the error isn't generic", async () => {
4040
const error = new S3ServiceException("Some S3 service exception.");
41-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
42-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
41+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
42+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
4343
error.name = "ServiceException";
4444
const bucketName = "amzn-s3-demo-bucket";
4545
send.mockRejectedValueOnce(error);

‎javascriptv3/example_code/s3/tests/delete-bucket.unit.test.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ describe("delete-bucket", () => {
3131

3232
it("should log a relevant error when the bucket doesn't exist", async () => {
3333
const error = new S3ServiceException("The specified bucket does not exist");
34-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
35-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
34+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
35+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
3636
error.name = "NoSuchBucket";
3737
send.mockRejectedValueOnce(error);
3838

@@ -47,8 +47,8 @@ describe("delete-bucket", () => {
4747

4848
it("should indicate a failure came from S3 when the error isn't generic", async () => {
4949
const error = new S3ServiceException("Some S3 service exception.");
50-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
51-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
50+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
51+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
5252
error.name = "ServiceException";
5353
send.mockRejectedValueOnce(error);
5454

‎javascriptv3/example_code/s3/tests/delete-object.unit.test.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ describe("delete-object", () => {
3434

3535
it("should log a relevant error when the bucket doesn't exist", async () => {
3636
const error = new S3ServiceException("The specified bucket does not exist");
37-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
38-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
37+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
38+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
3939
error.name = "NoSuchBucket";
4040
const bucketName = "amzn-s3-demo-bucket";
4141
send.mockRejectedValueOnce(error);
@@ -51,8 +51,8 @@ describe("delete-object", () => {
5151

5252
it("should indicate a failure came from S3 when the error isn't generic", async () => {
5353
const error = new S3ServiceException("Some S3 service exception.");
54-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
55-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
54+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
55+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
5656
error.name = "ServiceException";
5757
const bucketName = "amzn-s3-demo-bucket";
5858
send.mockRejectedValueOnce(error);

‎javascriptv3/example_code/s3/tests/delete-objects.unit.test.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ describe("delete-objects", () => {
3636

3737
it("should log a relevant error when the bucket doesn't exist", async () => {
3838
const error = new S3ServiceException("The specified bucket does not exist");
39-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
40-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
39+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
40+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
4141
error.name = "NoSuchBucket";
4242
const bucketName = "amzn-s3-demo-bucket";
4343
send.mockRejectedValueOnce(error);
@@ -53,8 +53,8 @@ describe("delete-objects", () => {
5353

5454
it("should indicate a failure came from S3 when the error isn't generic", async () => {
5555
const error = new S3ServiceException("Some S3 service exception.");
56-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
57-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
56+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
57+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
5858
error.name = "ServiceException";
5959
const bucketName = "amzn-s3-demo-bucket";
6060
send.mockRejectedValueOnce(error);

‎javascriptv3/example_code/s3/tests/get-bucket-acl.unit.test.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ describe("get-bucket-acl", () => {
3636

3737
it("should log a relevant error when the bucket doesn't exist", async () => {
3838
const error = new S3ServiceException("The specified bucket does not exist");
39-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
40-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
39+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
40+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
4141
error.name = "NoSuchBucket";
4242
const bucketName = "amzn-s3-demo-bucket";
4343
send.mockRejectedValueOnce(error);
@@ -53,8 +53,8 @@ describe("get-bucket-acl", () => {
5353

5454
it("should indicate a failure came from S3 when the error isn't generic", async () => {
5555
const error = new S3ServiceException("Some S3 service exception.");
56-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
57-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
56+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
57+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
5858
error.name = "ServiceException";
5959
const bucketName = "amzn-s3-demo-bucket";
6060
send.mockRejectedValueOnce(error);

‎javascriptv3/example_code/s3/tests/get-bucket-cors.unit.test.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ describe("get-bucket-cors", () => {
4949

5050
it("should log a relevant error when the bucket doesn't exist", async () => {
5151
const error = new S3ServiceException("The specified bucket does not exist");
52-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
53-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
52+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
53+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
5454
error.name = "NoSuchBucket";
5555
const bucketName = "amzn-s3-demo-bucket";
5656
send.mockRejectedValueOnce(error);
@@ -66,8 +66,8 @@ describe("get-bucket-cors", () => {
6666

6767
it("should indicate a failure came from S3 when the error isn't generic", async () => {
6868
const error = new S3ServiceException("Some S3 service exception.");
69-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
70-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
69+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
70+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
7171
error.name = "ServiceException";
7272
const bucketName = "amzn-s3-demo-bucket";
7373
send.mockRejectedValueOnce(error);

‎javascriptv3/example_code/s3/tests/get-bucket-policy.unit.test.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ describe("get-bucket-policy", () => {
3333

3434
it("should log a relevant error when the bucket doesn't exist", async () => {
3535
const error = new S3ServiceException("The specified bucket does not exist");
36-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
37-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
36+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
37+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
3838
error.name = "NoSuchBucket";
3939
const bucketName = "amzn-s3-demo-bucket";
4040
send.mockRejectedValueOnce(error);
@@ -50,8 +50,8 @@ describe("get-bucket-policy", () => {
5050

5151
it("should indicate a failure came from S3 when the error isn't generic", async () => {
5252
const error = new S3ServiceException("Some S3 service exception.");
53-
error.$fault = "server"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
54-
error.$metadata = "metadata"; // Workaround until PR is released. https://code.amazon.com/reviews/CR-171722725/revisions/1#/reviewers
53+
error.$fault = "server"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
54+
error.$metadata = "metadata"; // Workaround until PR is released. https://github.com/smithy-lang/smithy-typescript/pull/1503
5555
error.name = "ServiceException";
5656
const bucketName = "amzn-s3-demo-bucket";
5757
send.mockRejectedValueOnce(error);

0 commit comments

Comments
 (0)