Skip to content

Commit a8b8860

Browse files
committed
[mlir][vector] Remove redundant tests
We ended up with a duplicate test case post llvm#150284 - this PR removes that. I am also renaming the corresponding test function name, which is no longer valid (*). (*) `@extract_from_0d_splatlike_broadcast_regression` implies that all the tested vectors are rank-0, but that is not the case.
1 parent 573b377 commit a8b8860

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

mlir/test/Dialect/Vector/canonicalize.mlir

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3236,23 +3236,19 @@ func.func @rank_1_shuffle_to_interleave(%arg0: vector<6xi32>, %arg1: vector<6xi3
32363236

32373237
// -----
32383238

3239-
// CHECK-LABEL: func @extract_from_0d_splatlike_broadcast_regression(
3239+
// CHECK-LABEL: func @extract_from_splatlike_broadcast(
32403240
// CHECK-SAME: %[[A:.*]]: f32, %[[B:.*]]: vector<f32>, %[[C:.*]]: vector<2xf32>)
3241-
func.func @extract_from_0d_splatlike_broadcast_regression(%a: f32, %b: vector<f32>, %c: vector<2xf32>) -> (f32, f32, f32, f32, f32, vector<6x7xf32>, vector<3xf32>) {
3242-
// Splat/broadcast scalar to 0D and extract scalar.
3241+
func.func @extract_from_splatlike_broadcast(%a: f32, %b: vector<f32>, %c: vector<2xf32>) -> (f32, f32, f32, f32, vector<6x7xf32>, vector<3xf32>) {
3242+
// Broadcast scalar to 0D and extract scalar.
32433243
%0 = vector.broadcast %a : f32 to vector<f32>
32443244
%1 = vector.extract %0[] : f32 from vector<f32>
32453245

3246-
// Broadcast scalar to 0D and extract scalar.
3247-
%2 = vector.broadcast %a : f32 to vector<f32>
3248-
%3 = vector.extract %2[] : f32 from vector<f32>
3249-
32503246
// Broadcast 0D to 3D and extract scalar.
32513247
// CHECK: %[[EXTRACT1:.*]] = vector.extract %[[B]][] : f32 from vector<f32>
32523248
%4 = vector.broadcast %b : vector<f32> to vector<1x2x4xf32>
32533249
%5 = vector.extract %4[0, 0, 1] : f32 from vector<1x2x4xf32>
32543250

3255-
// Splat/broadcast scalar to 2D and extract scalar.
3251+
// Broadcast scalar to 2D and extract scalar.
32563252
%6 = vector.broadcast %a : f32 to vector<2x3xf32>
32573253
%7 = vector.extract %6[0, 1] : f32 from vector<2x3xf32>
32583254

@@ -3268,8 +3264,8 @@ func.func @extract_from_0d_splatlike_broadcast_regression(%a: f32, %b: vector<f3
32683264
// CHECK: %[[EXTRACT3:.*]] = vector.broadcast %[[A]] : f32 to vector<3xf32>
32693265
%11 = vector.extract %6[1] : vector<3xf32> from vector<2x3xf32>
32703266

3271-
// CHECK: return %[[A]], %[[A]], %[[EXTRACT1]], %[[A]], %[[A]], %[[EXTRACT2]], %[[EXTRACT3]]
3272-
return %1, %3, %5, %7, %9, %10, %11 : f32, f32, f32, f32, f32, vector<6x7xf32>, vector<3xf32>
3267+
// CHECK: return %[[A]], %[[EXTRACT1]], %[[A]], %[[A]], %[[EXTRACT2]], %[[EXTRACT3]]
3268+
return %1, %5, %7, %9, %10, %11 : f32, f32, f32, f32, vector<6x7xf32>, vector<3xf32>
32733269
}
32743270

32753271
// -----

0 commit comments

Comments
 (0)