Skip to content

Commit 911c366

Browse files
author
Barry Weiss
committed
Add changes per PR Fix broken ingest and start langchain-ai#94
1 parent 0fd8640 commit 911c366

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

ingest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
def ingest_docs():
1111
"""Get documents from web pages."""
12-
loader = ReadTheDocsLoader("langchain.readthedocs.io/en/latest/")
12+
loader = ReadTheDocsLoader("langchain.readthedocs.io/en/latest/", features="lxml")
1313
raw_documents = loader.load()
1414
text_splitter = RecursiveCharacterTextSplitter(
1515
chunk_size=1000,

query_data.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
import os
33
from dotenv import load_dotenv
44

5-
from langchain.callbacks.base import AsyncCallbackManager
5+
from langchain.callbacks.manager import AsyncCallbackManager
66
from langchain.callbacks.tracers import LangChainTracer
7-
from langchain.chains import ChatVectorDBChain
7+
from langchain.chains import ConversationalRetrievalChain
88
from langchain.chains.chat_vector_db.prompts import (CONDENSE_QUESTION_PROMPT,
99
QA_PROMPT)
1010
from langchain.chains.llm import LLMChain
@@ -20,9 +20,9 @@
2020

2121
def get_chain(
2222
vectorstore: VectorStore, question_handler, stream_handler, tracing: bool = False
23-
) -> ChatVectorDBChain:
24-
"""Create a ChatVectorDBChain for question/answering."""
25-
# Construct a ChatVectorDBChain with a streaming llm for combine docs
23+
) -> ConversationalRetrievalChain:
24+
"""Create a ConversationalRetrievalChain for question/answering."""
25+
# Construct a ConversationalRetrievalChain with a streaming llm for combine docs
2626
# and a separate, non-streaming llm for question generation
2727
manager = AsyncCallbackManager([])
2828
question_manager = AsyncCallbackManager([question_handler])
@@ -53,8 +53,8 @@ def get_chain(
5353
streaming_llm, chain_type="stuff", prompt=QA_PROMPT, callback_manager=manager
5454
)
5555

56-
qa = ChatVectorDBChain(
57-
vectorstore=vectorstore,
56+
qa = ConversationalRetrievalChain(
57+
retriever=vectorstore.as_retriever(),
5858
combine_docs_chain=doc_chain,
5959
question_generator=question_generator,
6060
callback_manager=manager,

0 commit comments

Comments
 (0)