Skip to content

Commit 418a70c

Browse files
Address feedback
1 parent e87d7e8 commit 418a70c

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ END_UNRELEASED_TEMPLATE
104104
* 3.12.11
105105
* 3.13.5
106106
* 3.14.0b3
107-
* (rules) `main_module` now works without needing to set `bootstrap_impl=script`
107+
* (rules) {obj}`main_module` now works without needing to set {obj}`--bootstrap_impl=script`
108108

109109
{#v0-0-0-removed}
110110
### Removed

tests/bootstrap_impls/BUILD.bazel

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -124,24 +124,25 @@ py_reconfig_test(
124124
main = "sys_path_order_test.py",
125125
)
126126

127-
py_reconfig_test(
128-
name = "main_module_test",
127+
py_library(
128+
name = "main_module_lib",
129129
srcs = ["main_module.py"],
130+
imports = ["."],
131+
)
132+
133+
py_reconfig_test(
134+
name = "main_module_script_test",
130135
bootstrap_impl = "script",
131136
main_module = "tests.bootstrap_impls.main_module",
132137
target_compatible_with = SUPPORTS_BOOTSTRAP_SCRIPT,
133-
)
134-
135-
py_library(
136-
name = "main_module_system_python_lib",
137-
srcs = ["main_module.py"],
138+
deps = [":main_module_lib"],
138139
)
139140

140141
py_reconfig_test(
141142
name = "main_module_system_python_test",
142143
bootstrap_impl = "system_python",
143144
main_module = "tests.bootstrap_impls.main_module",
144-
deps = [":main_module_system_python_lib"],
145+
deps = [":main_module_lib"],
145146
)
146147

147148
sh_py_run_test(

0 commit comments

Comments
 (0)