Feedback from review

Renegenerated IfExp integration test

Author: Juanjo Alvarez

ANNOTATION.md

@@ -99,7 +99,7 @@
 | /self::\*\[@InternalType='Module'\]//\*\[@InternalType='If'\]/\*\[@InternalType='Compare'\]/\*\[@InternalType='Compare\.ops'\] | BinaryExpressionOp |
 | /self::\*\[@InternalType='Module'\]//\*\[@InternalType='If'\]/\*\[@InternalType='Compare'\]/\*\[@InternalType='Compare\.comparators'\] | BinaryExpressionRight |
 | /self::\*\[@InternalType='Module'\]//\*\[@InternalType='If'\]/\*\[@InternalType='Compare'\]/\*\[@internalRole\]\[@internalRole='left'\] | BinaryExpressionLeft |
-| /self::\*\[@InternalType='Module'\]//\*\[@InternalType='IfExp'\] | If, Expression, Statement |
+| /self::\*\[@InternalType='Module'\]//\*\[@InternalType='IfExp'\] | If, Expression |
 | /self::\*\[@InternalType='Module'\]//\*\[@InternalType='IfExp'\]/\*\[@internalRole\]\[@internalRole='body'\] | IfBody |
 | /self::\*\[@InternalType='Module'\]//\*\[@InternalType='IfExp'\]/\*\[@internalRole\]\[@internalRole='test'\] | IfCondition |
 | /self::\*\[@InternalType='Module'\]//\*\[@InternalType='IfExp'\]/\*\[@internalRole\]\[@internalRole='orelse'\] | IfElse |

driver/normalizer/annotation.go

@@ -270,7 +270,7 @@ var AnnotationRules = On(Any).Self(
 				On(HasInternalRole("left")).Roles(BinaryExpressionLeft),
 			),
 		),
-		On(HasInternalType(pyast.IfExp)).Roles(If, Expression, Statement).Children(
+		On(HasInternalType(pyast.IfExp)).Roles(If, Expression).Children(
 			// These are used on ifexpressions (a = 1 if x else 2)
 			On(HasInternalRole("body")).Roles(IfBody),
 			On(HasInternalRole("test")).Roles(IfCondition),

tests/ifexpression.py.uast

@@ -42,7 +42,7 @@ Module {
 .  .  .  .  .  }
 .  .  .  .  }
 .  .  .  .  1: IfExp {
-.  .  .  .  .  Roles: AssignmentValue,If,Expression,Statement
+.  .  .  .  .  Roles: AssignmentValue,If,Expression
 .  .  .  .  .  StartPosition: {
 .  .  .  .  .  .  Offset: 4
 .  .  .  .  .  .  Line: 1