Skip to content

Commit 49c8914

Browse files
author
Sakari Rautiainen
authored
Merge pull request #120 from lex/deprecated-methods
mark some methods as deprecated
2 parents d0d3645 + 3ee1c9b commit 49c8914

File tree

1 file changed

+24
-11
lines changed

1 file changed

+24
-11
lines changed

testdroid/__init__.py

Lines changed: 24 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -391,9 +391,11 @@ def print_projects(self, limit=0):
391391
for project in self.get_projects(limit)['data']:
392392
print("%s %s \"%s\"" % (str(project['id']).ljust(10), project['type'].ljust(15), project['name']))
393393

394-
""" Upload application file to project
394+
""" ***DEPRECATED*** Upload application file to project
395+
Consider using upload_file() instead.
395396
"""
396397
def upload_application_file(self, project_id, filename):
398+
logger.warning('WARNING: This method has been deprecated and will be removed in the future.')
397399
me = self.get_me()
398400
path = "users/%s/projects/%s/files/application" % (me['id'], project_id)
399401
return self.upload(path=path, filename=filename)
@@ -405,9 +407,11 @@ def upload_file(self, filename):
405407
path = "users/%s/files" % (me['id'])
406408
return self.upload(path=path, filename=filename)
407409

408-
""" Upload test file to project
410+
""" ***DEPRECATED*** Upload test file to project
411+
Consider using upload_file() instead.
409412
"""
410413
def upload_test_file(self, project_id, filename):
414+
logger.warning('WARNING: This method has been deprecated and will be removed in the future.')
411415
me = self.get_me()
412416
path = "users/%s/projects/%s/files/test" % (me['id'], project_id)
413417
return self.upload(path=path, filename=filename)
@@ -425,9 +429,11 @@ def get_project_parameters(self, project_id):
425429
path = "me/projects/%s/config/parameters" % ( project_id )
426430
return self.get(path=path)
427431

428-
""" Upload additional data file to project
432+
""" ***DEPRECATED*** Upload additional data file to project
433+
Consider using upload_file() instead.
429434
"""
430435
def upload_data_file(self, project_id, filename):
436+
logger.warning('WARNING: This method has been deprecated and will be removed in the future.')
431437
me = self.get_me()
432438
path = "users/%s/projects/%s/files/data" % (me['id'], project_id)
433439
return self.upload(path=path, filename=filename)
@@ -446,9 +452,11 @@ def get_project_config(self, project_id):
446452
path = "me/projects/%s/config" % ( project_id )
447453
return self.get(path=path)
448454

449-
""" Set project config according to http://docs.testdroid.com/_pages/client.html#project-config
455+
""" ***DEPRECATED*** Set project config according to http://docs.testdroid.com/_pages/client.html#project-config
456+
Consider using start_test_run_using_config() instead.
450457
"""
451458
def set_project_config(self, project_id, payload):
459+
logger.warning('WARNING: This method has been deprecated and will be removed in the future.')
452460
#set the project config to reflect the given json payload
453461
#e.g.: {'usedDeviceGroupId': 1234}
454462
if isinstance(payload, str):
@@ -457,9 +465,11 @@ def set_project_config(self, project_id, payload):
457465
path = "users/%s/projects/%s/config" % ( me['id'], project_id )
458466
return self.post(path=path, payload=payload)
459467

460-
"""Set project framework based on a framework integer id
468+
""" ***DEPRECATED*** Set project framework based on a framework integer id
469+
Consider using start_test_run_using_config() instead.
461470
"""
462471
def set_project_framework(self, project_id, frameworkId):
472+
logger.warning('WARNING: This method has been deprecated and will be removed in the future.')
463473
path = "projects/%(project_id)s/frameworks" % {
464474
'project_id': project_id
465475
}
@@ -483,9 +493,11 @@ def start_test_run_using_config(self, test_run_config={}):
483493
test_run = self.post(path=path, payload=test_run_config, headers={'Content-type': 'application/json', 'Accept': 'application/json'})
484494
return test_run
485495

486-
""" Start a test run on a device group
496+
""" ***DEPRECATED*** Start a test run on a device group
497+
Consider using start_test_run_using_config() instead.
487498
"""
488499
def start_test_run(self, project_id, device_group_id=None, device_model_ids=None, name=None, additional_params={}):
500+
logger.warning('WARNING: This method has been deprecated and will be removed in the future.')
489501
# check project validity
490502
project = self.get_project(project_id)
491503
if not 'id' in project:
@@ -964,16 +976,17 @@ def format_epilog(self, formatter):
964976
CALABASH_IOS
965977
delete-project <id> Delete a project
966978
projects Get projects
967-
upload-application <project-id> <filename> Upload application to project
968-
upload-test <project-id> <filename> Upload test file to project
969-
upload-data <project-id> <filename> Upload additional data file to project
979+
upload-application <project-id> <filename> ***DEPRECATED*** Upload application to project
980+
upload-test <project-id> <filename> ***DEPRECATED*** Upload test file to project
981+
upload-data <project-id> <filename> ***DEPRECATED*** Upload additional data file to project
970982
upload-file <filename> Upload to "Files"
971983
set-project-config <project-id> <config-json>
972-
Change the project config parameters as facilitated by the API:
984+
***DEPRECATED*** Change the project config parameters as facilitated by the API:
973985
http://docs.testdroid.com/_pages/client.html#project-config
974986
e.g.:
975987
./testdroid-api-client set-project-config 1234 '{"limitationType":"CLASS", "limitationValue":"com.foo.test.VerifyFoo"}'
976-
start-test-run <project-id> <device-group-id> Start a test run
988+
start-test-run <project-id> <device-group-id>
989+
***DEPRECATED*** Start a test run
977990
start-wait-download-test-run <project-id> <device-group-id>
978991
Start a test run, await completion (polling) and
979992
download results

0 commit comments

Comments
 (0)