Skip to content

fix compilation error with later 3.0.x versions of arduino-esp32 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix compilation error with later 3.0.x versions of arduino-esp32 #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
585bf7a
fix compilation error with later 3.0.x versions of arduino-esp32
jscrane Jan 12, 2025
43c5acb
bugfix: confusing parameter with method name
jscrane Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/I2S/DMABufferDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class DMABufferDescriptor : protected lldesc_t
if (!b)
DEBUG_PRINTLN("Failed to alloc DMABufferDescriptor");
b->init();
if (allocateBuffer)
if (allocBuffer)
b->setBuffer(allocateBuffer(bytes, clear, clearValue), bytes);
return b;
}
Expand Down
2 changes: 1 addition & 1 deletion src/VGA/VGA.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class VGA : public VGAMode, public VGAPinConfig

// TODO This function should be pure virtual, but it is currently implemented with added arguments in children classes
virtual bool init(const Mode &mode, const int *pinMap, const int bitCount, const int clockPin = -1)
{}
{ return false; }

virtual bool init(const Mode &mode, const PinConfig &pinConfig) = 0;

Expand Down