remove more lodash.map() calls

dynst · dynst · commit ccdc4b026296 · 2025-06-30T19:56:02.000Z
find packages/ -type f -exec sed -i -E \
  -e 's|_\.map\(([^,]+), function\(([^\)]*)\) \{|\1.map((\2) =&gt; {|g' {} +
find packages/ -type f -exec sed -i -E \
  -e 's/_\.map\(([^,]+), ([^ ]+) =&gt; \{/\1.map(\2 =&gt; {/g' {} +
diff --git a/packages/bitcore-lib-cash/lib/encoding/base58.js b/packages/bitcore-lib-cash/lib/encoding/base58.js
@@ -26,7 +26,7 @@ Base58.validCharacters = function validCharacters(chars) {
   if (buffer.Buffer.isBuffer(chars)) {
     chars = chars.toString();
   }
-  return _.every(_.map(chars, function(char) { return ALPHABET.includes(char); }));
+  return _.every(chars.map((char) => { return ALPHABET.includes(char); }));
 };
 
 Base58.prototype.set = function(obj) {
diff --git a/packages/bitcore-lib-doge/lib/encoding/base58.js b/packages/bitcore-lib-doge/lib/encoding/base58.js
@@ -26,7 +26,7 @@ Base58.validCharacters = function validCharacters(chars) {
   if (buffer.Buffer.isBuffer(chars)) {
     chars = chars.toString();
   }
-  return _.every(_.map(chars, function(char) { return (ALPHABET.includes(char)) }));
+  return _.every(chars.map((char) => { return (ALPHABET.includes(char)) }));
 };
 
 Base58.prototype.set = function(obj) {
diff --git a/packages/bitcore-lib-ltc/lib/encoding/base58.js b/packages/bitcore-lib-ltc/lib/encoding/base58.js
@@ -25,7 +25,7 @@ Base58.validCharacters = function validCharacters(chars) {
   if (Buffer.isBuffer(chars)) {
     chars = chars.toString();
   }
-  return _.every(_.map(chars, function(char) { return (ALPHABET.includes(char)) }));
+  return _.every(chars.map((char) => { return (ALPHABET.includes(char)) }));
 };
 
 Base58.prototype.set = function(obj) {
diff --git a/packages/bitcore-lib/lib/encoding/base58.js b/packages/bitcore-lib/lib/encoding/base58.js
@@ -26,7 +26,7 @@ Base58.validCharacters = function validCharacters(chars) {
   if (buffer.Buffer.isBuffer(chars)) {
     chars = chars.toString();
   }
-  return _.every(_.map(chars, function(char) { return ALPHABET.includes(char); }));
+  return _.every(chars.map((char) => { return ALPHABET.includes(char); }));
 };
 
 Base58.prototype.set = function(obj) {
diff --git a/packages/bitcore-lib/lib/transaction/input/multisig.js b/packages/bitcore-lib/lib/transaction/input/multisig.js
@@ -44,13 +44,13 @@ inherits(MultiSigInput, Input);
 MultiSigInput.prototype.toObject = function() {
   var obj = Input.prototype.toObject.apply(this, arguments);
   obj.threshold = this.threshold;
-  obj.publicKeys = _.map(this.publicKeys, function(publicKey) { return publicKey.toString(); });
+  obj.publicKeys = this.publicKeys.map((publicKey) => { return publicKey.toString(); });
   obj.signatures = this._serializeSignatures();
   return obj;
 };
 
 MultiSigInput.prototype._deserializeSignatures = function(signatures) {
-  return _.map(signatures, function(signature) {
+  return signatures.map((signature) => {
     if (!signature) {
       return undefined;
     }
@@ -59,7 +59,7 @@ MultiSigInput.prototype._deserializeSignatures = function(signatures) {
 };
 
 MultiSigInput.prototype._serializeSignatures = function() {
-  return _.map(this.signatures, function(signature) {
+  return this.signatures.map((signature) => {
     if (!signature) {
       return undefined;
     }
diff --git a/packages/bitcore-wallet-service/src/lib/bchaddresstranslator.ts b/packages/bitcore-wallet-service/src/lib/bchaddresstranslator.ts
@@ -34,7 +34,7 @@ export class BCHAddressTranslator {
       ret = addresses;
     } else {
       ret = _.filter(
-        _.map(addresses, x => {
+        addresses.map(x => {
           const bitcore = Bitcore_[from == 'legacy' ? 'btc' : 'bch'];
           let orig;
 
diff --git a/packages/bitcore-wallet-service/src/lib/chain/btc/index.ts b/packages/bitcore-wallet-service/src/lib/chain/btc/index.ts
@@ -432,7 +432,7 @@ export class BtcChain implements IChain {
         'Failed state: t.outputs.length not equal to outputOrder.length at <getBitcoreTx()>'
       );
       t.sortOutputs(outputs => {
-        return _.map(outputOrder, i => {
+        return outputOrder.map(i => {
           return outputs[i];
         });
       });
diff --git a/packages/bitcore-wallet-service/src/lib/model/address.ts b/packages/bitcore-wallet-service/src/lib/model/address.ts
@@ -108,7 +108,7 @@ export class Address {
       }
     }
 
-    let publicKeys = _.map(publicKeyRing, item => {
+    let publicKeys = publicKeyRing.map(item => {
       const xpub = Address.Bitcore[chain]
         ? new Address.Bitcore[chain].HDPublicKey(item.xPubKey)
         : new Address.Bitcore.btc.HDPublicKey(item.xPubKey);
diff --git a/packages/bitcore-wallet-service/src/lib/model/txproposal.ts b/packages/bitcore-wallet-service/src/lib/model/txproposal.ts
@@ -331,7 +331,7 @@ export class TxProposal {
     x.txids = obj.txids;
     x.broadcastedOn = obj.broadcastedOn;
     x.inputPaths = obj.inputPaths;
-    x.actions = _.map(obj.actions, action => {
+    x.actions = obj.actions.map(action => {
       return TxProposalAction.fromObj(action);
     });
     x.outputOrder = obj.outputOrder;
@@ -421,7 +421,7 @@ export class TxProposal {
       return a.type == 'accept';
     });
 
-    return _.map(acceptedActions, x => {
+    return acceptedActions.map(x => {
       return {
         signatures: x.signatures,
         xpub: x.xpub
diff --git a/packages/bitcore-wallet-service/src/lib/model/txproposal_legacy.ts b/packages/bitcore-wallet-service/src/lib/model/txproposal_legacy.ts
@@ -117,7 +117,7 @@ export class TxProposalLegacy {
     x.txid = obj.txid;
     x.broadcastedOn = obj.broadcastedOn;
     x.inputPaths = obj.inputPaths;
-    x.actions = _.map(obj.actions, function(action) {
+    x.actions = obj.actions.map((action) => {
       return TxProposalAction.fromObj(action);
     });
     x.outputOrder = obj.outputOrder;
diff --git a/packages/bitcore-wallet-service/src/lib/model/wallet.ts b/packages/bitcore-wallet-service/src/lib/model/wallet.ts
@@ -156,7 +156,7 @@ export class Wallet {
     x.singleAddress = !!obj.singleAddress;
     x.status = obj.status;
     x.publicKeyRing = obj.publicKeyRing;
-    x.copayers = _.map(obj.copayers, copayer => {
+    x.copayers = obj.copayers.map(copayer => {
       return Copayer.fromObj(copayer);
     });
     x.pubKey = obj.pubKey;
@@ -235,7 +235,7 @@ export class Wallet {
   }
 
   _updatePublicKeyRing() {
-    this.publicKeyRing = _.map(this.copayers, copayer => {
+    this.publicKeyRing = this.copayers.map(copayer => {
       return _.pick(copayer, ['xPubKey', 'requestPubKey']);
     });
   }
diff --git a/packages/bitcore-wallet-service/src/lib/pushnotificationsservice.ts b/packages/bitcore-wallet-service/src/lib/pushnotificationsservice.ts
@@ -206,7 +206,7 @@ export class PushNotificationsService {
               this._getSubscriptions(notification, notifType, recipientsList, contents, next);
             },
             (subs, next) => {
-              const notifications = _.map(subs, sub => {
+              const notifications = subs.map(sub => {
                 if (notification.type === 'NewTxProposal' && sub.copayerId === notification.creatorId) return;
 
                 const tokenAddress =
@@ -386,7 +386,7 @@ export class PushNotificationsService {
         if (_.isEmpty(preferences)) preferences = [];
 
         const recipientPreferences = _.compact(
-          _.map(preferences, p => {
+          preferences.map(p => {
             if (!_.includes(this.availableLanguages, p.language)) {
               if (p.language) logger.warn('Language for notifications "' + p.language + '" not available.');
               p.language = this.defaultLanguage;
@@ -403,7 +403,7 @@ export class PushNotificationsService {
         const copayers = _.keyBy(recipientPreferences, 'copayerId');
 
         const recipientsList = _.compact(
-          _.map(wallet.copayers, copayer => {
+          wallet.copayers.map(copayer => {
             const p = copayers[copayer.id] || {
               language: this.defaultLanguage,
               unit: this.defaultUnit
@@ -565,7 +565,7 @@ export class PushNotificationsService {
       }
 
       if (notification.type == 'TxProposalFinallyRejected' && data.rejectedBy) {
-        const rejectors = _.map(data.rejectedBy, copayerId => {
+        const rejectors = data.rejectedBy.map(copayerId => {
           return wallet.copayers.find(c => c.id === copayerId).name;
         });
         data.rejectorsNames = rejectors.join(', ');
diff --git a/packages/bitcore-wallet-service/src/lib/stats.ts b/packages/bitcore-wallet-service/src/lib/stats.ts
@@ -93,7 +93,7 @@ export class Stats {
       .toArray((err, results) => {
         if (err) return cb(err);
         const stats = {
-          byDay: _.map(results, record => {
+          byDay: results.map(record => {
             const day = moment(record._id.day).format('YYYYMMDD');
             return {
               day,
@@ -123,7 +123,7 @@ export class Stats {
       .toArray((err, results) => {
         if (err) return cb(err);
         const stats = {
-          byDay: _.map(results, record => {
+          byDay: results.map(record => {
             const day = moment(record._id.day).format('YYYYMMDD');
             return {
               day,
diff --git a/packages/bitcore-wallet-service/src/lib/storage.ts b/packages/bitcore-wallet-service/src/lib/storage.ts
@@ -237,7 +237,7 @@ export class Storage {
   }
 
   storeWalletAndUpdateCopayersLookup(wallet, cb) {
-    const copayerLookups = _.map(wallet.copayers, copayer => {
+    const copayerLookups = wallet.copayers.map(copayer => {
       try {
         $.checkState(
           copayer.requestPubKeys,
@@ -368,7 +368,7 @@ export class Storage {
       .toArray((err, result) => {
         if (err) return cb(err);
         if (!result) return cb();
-        const txs = _.map(result, tx => {
+        const txs = result.map(tx => {
           return TxProposal.fromObj(tx);
         });
         return cb(null, txs);
@@ -391,7 +391,7 @@ export class Storage {
           const multisigTxpsInfoByTransactionHash: any = _.groupBy(multisigTxpsInfo, 'transactionHash');
           const actionsById = {};
           const txs = _.compact(
-            _.map(result, tx => {
+            result.map(tx => {
               if (!tx.multisigContractAddress) {
                 return undefined;
               }
@@ -434,7 +434,7 @@ export class Storage {
       .toArray((err, result) => {
         if (err) return cb(err);
         if (!result) return cb();
-        const txs = _.map(result, tx => {
+        const txs = result.map(tx => {
           return TxProposal.fromObj(tx);
         });
         return this._completeTxData(walletId, txs, cb);
@@ -473,7 +473,7 @@ export class Storage {
       .toArray((err, result) => {
         if (err) return cb(err);
         if (!result) return cb();
-        const txs = _.map(result, tx => {
+        const txs = result.map(tx => {
           return TxProposal.fromObj(tx);
         });
         return this._completeTxData(walletId, txs, cb);
@@ -517,7 +517,7 @@ export class Storage {
       .toArray((err, result) => {
         if (err) return cb(err);
         if (!result) return cb();
-        const txs = _.map(result, tx => {
+        const txs = result.map(tx => {
           return TxProposal.fromObj(tx);
         });
         return this._completeTxData(walletId, txs, cb);
@@ -554,7 +554,7 @@ export class Storage {
       .toArray((err, result) => {
         if (err) return cb(err);
         if (!result) return cb();
-        const notifications = _.map(result, notification => {
+        const notifications = result.map(notification => {
           return Notification.fromObj(notification);
         });
         return cb(null, notifications);
@@ -873,7 +873,7 @@ export class Storage {
         }
         if (!result) return cb();
 
-        const preferences = _.map([].concat(result), r => {
+        const preferences = [].concat(result).map(r => {
           return Preferences.fromObj(r);
         });
         if (copayerId) {
@@ -923,7 +923,7 @@ export class Storage {
         if (err) return cb(err);
         if (!result || _.isEmpty(result)) return cb(null, []);
 
-        const emails = _.map(result, x => {
+        const emails = result.map(x => {
           return Email.fromObj(x);
         });
 
@@ -1322,7 +1322,7 @@ export class Storage {
       .toArray((err, result) => {
         if (err) return cb(err);
         const notes = _.compact(
-          _.map(result, note => {
+          result.map(note => {
             return TxNote.fromObj(note);
           })
         );
@@ -1382,7 +1382,7 @@ export class Storage {
 
         if (!result) return cb();
 
-        const tokens = _.map([].concat(result), r => {
+        const tokens = [].concat(result).map(r => {
           return PushNotificationSub.fromObj(r);
         });
         return cb(null, tokens);
@@ -1404,7 +1404,7 @@ export class Storage {
 
         if (!result) return cb();
 
-        const tokens = _.map([].concat(result), r => {
+        const tokens = [].concat(result).map(r => {
           return PushNotificationSub.fromObj(r);
         });
         return cb(null, tokens);
diff --git a/packages/bitcore-wallet-service/test/integration/helpers.js b/packages/bitcore-wallet-service/test/integration/helpers.js
@@ -406,7 +406,7 @@ helpers.stubUtxos = function(server, wallet, amounts, opts, cb) {
     function(addresses, next) {
       addresses.should.not.be.empty;
 
-      var utxos = _.compact(_.map([].concat(amounts), function(amount, i) {
+      var utxos = _.compact([].concat(amounts).map((amount, i) => {
         var parsed = helpers._parseAmount(amount);
 
         if (parsed.amount <= 0) return null;
@@ -619,7 +619,7 @@ helpers.clientSign = function(txp, derivedXPrivKey) {
       });
 
       var t = ChainService.getBitcoreTx(txp);
-      signatures = _.map(privs, function(priv, i) {
+      signatures = privs.map((priv, i) => {
         return t.getSignatures(priv, undefined, txp.signingMethod);
       });
 
diff --git a/packages/bitcore-wallet-service/test/integration/history.js b/packages/bitcore-wallet-service/test/integration/history.js
@@ -916,7 +916,7 @@ describe('History', function() {
       }];
 
       var timestamps = [50, 40, 30, 20, 10];
-      var txs = _.map(timestamps, function(ts, idx) {
+      var txs = timestamps.map((ts, idx) => {
         return {
           txid: (idx + 1).toString(),
           confirmations: ts / 10,
diff --git a/packages/bitcore-wallet-service/test/integration/pushNotifications.js b/packages/bitcore-wallet-service/test/integration/pushNotifications.js
diff --git a/packages/bitcore-wallet-service/test/integration/server.js b/packages/bitcore-wallet-service/test/integration/server.js
diff --git a/packages/bitcore-wallet-service/test/storage.js b/packages/bitcore-wallet-service/test/storage.js
diff --git a/packages/bitcore-wallet/bin/cli-utils.js b/packages/bitcore-wallet/bin/cli-utils.js

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ Base58.validCharacters = function validCharacters(chars) {`
`26`	`26`	`if (buffer.Buffer.isBuffer(chars)) {`
`27`	`27`	`chars = chars.toString();`
`28`	`28`	`}`
`29`		`- return _.every(_.map(chars, function(char) { return ALPHABET.includes(char); }));`
	`29`	`+ return _.every(chars.map((char) => { return ALPHABET.includes(char); }));`
`30`	`30`	`};`
`31`	`31`
`32`	`32`	`Base58.prototype.set = function(obj) {`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ Base58.validCharacters = function validCharacters(chars) {`
`25`	`25`	`if (Buffer.isBuffer(chars)) {`
`26`	`26`	`chars = chars.toString();`
`27`	`27`	`}`
`28`		`- return _.every(_.map(chars, function(char) { return (ALPHABET.includes(char)) }));`
	`28`	`+ return _.every(chars.map((char) => { return (ALPHABET.includes(char)) }));`
`29`	`29`	`};`
`30`	`30`
`31`	`31`	`Base58.prototype.set = function(obj) {`
Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ export class Address {`
`108`	`108`	`}`
`109`	`109`	`}`
`110`	`110`
`111`		`- let publicKeys = _.map(publicKeyRing, item => {`
	`111`	`+ let publicKeys = publicKeyRing.map(item => {`
`112`	`112`	`const xpub = Address.Bitcore[chain]`
`113`	`113`	`? new Address.Bitcore[chain].HDPublicKey(item.xPubKey)`
`114`	`114`	`: new Address.Bitcore.btc.HDPublicKey(item.xPubKey);`