Skip to content

Commit 9de3747

Browse files
[PM-26109] Replace Ok with OK per Apple HIG (#1987)
1 parent 4b74c87 commit 9de3747

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

AuthenticatorShared/UI/Platform/Application/Utilities/Alert/AlertErrorTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class AlertErrorTests: BitwardenTestCase {
1010

1111
XCTAssertEqual(subject.title, "title")
1212
XCTAssertEqual(subject.message, "message")
13-
XCTAssertEqual(subject.alertActions, [AlertAction(title: "Ok", style: .cancel)])
13+
XCTAssertEqual(subject.alertActions, [AlertAction(title: Localizations.ok, style: .cancel)])
1414
}
1515

1616
/// `inputValidationAlert(error:)` creates an `Alert` for an input validation error.

BitwardenResources/Localizations/en.lproj/Localizable.strings

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"Name" = "Name";
5656
"No" = "No";
5757
"Notes" = "Notes";
58-
"Ok" = "Ok";
58+
"OK" = "OK";
5959
"Password" = "Password";
6060
"Save" = "Save";
6161
"Move" = "Move";
@@ -155,7 +155,7 @@
155155
"NoItems" = "There are no items in your vault.";
156156
"NoItemsTap" = "There are no items in your vault for this website/app. Tap to add one.";
157157
"NoUsernamePasswordConfigured" = "This login does not have a username or password configured.";
158-
"OkGotIt" = "Ok, got it!";
158+
"OKGotIt" = "OK, got it!";
159159
"OptionDefaults" = "Option defaults are set from the main Bitwarden app’s password generator tool.";
160160
"Options" = "Options";
161161
"Other" = "Other";

BitwardenShared/UI/Platform/Application/Utilities/Alert/Alert/AlertErrorTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class AlertErrorTests: BitwardenTestCase {
1010

1111
XCTAssertEqual(subject.title, "title")
1212
XCTAssertEqual(subject.message, "message")
13-
XCTAssertEqual(subject.alertActions, [AlertAction(title: "Ok", style: .cancel)])
13+
XCTAssertEqual(subject.alertActions, [AlertAction(title: Localizations.ok, style: .cancel)])
1414
}
1515

1616
/// `defaultAlert(error:)` constructs an `Alert` with the title and message based on the error,
@@ -20,7 +20,7 @@ class AlertErrorTests: BitwardenTestCase {
2020

2121
XCTAssertEqual(subject.title, Localizations.anErrorHasOccurred)
2222
XCTAssertEqual(subject.message, StateServiceError.noActiveAccount.errorDescription)
23-
XCTAssertEqual(subject.alertActions, [AlertAction(title: "Ok", style: .cancel)])
23+
XCTAssertEqual(subject.alertActions, [AlertAction(title: Localizations.ok, style: .cancel)])
2424
}
2525

2626
/// `inputValidationAlert(error:)` creates an `Alert` for an input validation error.

0 commit comments

Comments
 (0)