do not leak sql string

dorinhogea · dorinhogea · commit 9943e5ce897b · 2025-09-26T11:12:53.000-04:00
Signed-off-by: Dorin Hogea &lt;dhogea@bloomberg.net&gt;
diff --git a/db/sqlanalyze.c b/db/sqlanalyze.c
@@ -773,6 +773,7 @@ static int analyze_table_int(table_descriptor_t *td, struct thr_handle *thr_self
             sqlite3_free(sql); sql = NULL;
             goto error;
         }
+        sqlite3_free(sql); sql = NULL;
         if (!get_dbtable_by_name("sqlite_stat4")) continue;
         sql = sqlite3_mprintf("INSERT INTO sqlite_stat4(tbl, idx, neq, nlt, ndlt, sample) "
                 "SELECT tbl, '%q', neq, nlt, ndlt, sample FROM sqlite_stat4 "
@@ -784,6 +785,7 @@ static int analyze_table_int(table_descriptor_t *td, struct thr_handle *thr_self
             sqlite3_free(sql); sql = NULL;
             goto error;
         }
+        sqlite3_free(sql); sql = NULL;
     }
 
     if (rc)

Original file line number	Diff line number	Diff line change
`@@ -773,6 +773,7 @@ static int analyze_table_int(table_descriptor_t td, struct thr_handle thr_self`
`773`	`773`	`sqlite3_free(sql); sql = NULL;`
`774`	`774`	`goto error;`
`775`	`775`	`}`
	`776`	`+ sqlite3_free(sql); sql = NULL;`
`776`	`777`	`if (!get_dbtable_by_name("sqlite_stat4")) continue;`
`777`	`778`	`sql = sqlite3_mprintf("INSERT INTO sqlite_stat4(tbl, idx, neq, nlt, ndlt, sample) "`
`778`	`779`	`"SELECT tbl, '%q', neq, nlt, ndlt, sample FROM sqlite_stat4 "`
`@@ -784,6 +785,7 @@ static int analyze_table_int(table_descriptor_t td, struct thr_handle thr_self`
`784`	`785`	`sqlite3_free(sql); sql = NULL;`
`785`	`786`	`goto error;`
`786`	`787`	`}`
	`788`	`+ sqlite3_free(sql); sql = NULL;`
`787`	`789`	`}`
`788`	`790`
`789`	`791`	`if (rc)`