Skip to content

Commit e4e3b67

Browse files
author
boncey
committed
Make some of the tests less fragile
1 parent 8f49e40 commit e4e3b67

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

Flickr4Java/src/test/java/com/flickr4java/flickr/test/MembersInterfaceTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,16 @@
66
import static org.junit.Assert.assertNotNull;
77
import static org.junit.Assert.assertTrue;
88

9-
import java.util.HashSet;
10-
import java.util.Set;
11-
12-
import org.junit.Test;
13-
149
import com.flickr4java.flickr.FlickrException;
1510
import com.flickr4java.flickr.groups.members.Member;
1611
import com.flickr4java.flickr.groups.members.MembersInterface;
1712
import com.flickr4java.flickr.groups.members.MembersList;
1813

14+
import org.junit.Test;
15+
16+
import java.util.HashSet;
17+
import java.util.Set;
18+
1919
/**
2020
* @author mago
2121
* @version $Id: MembersInterfaceTest.java,v 1.3 2009/07/11 20:30:27 x-mago Exp $
@@ -26,15 +26,15 @@ public class MembersInterfaceTest extends Flickr4JavaTest {
2626
public void testGetList() throws FlickrException {
2727
MembersInterface iface = flickr.getMembersInterface();
2828
// Group: Urban fragments
29-
String id = "64262537@N00";
29+
String id = testProperties.getGroupId();
3030
Set<String> memberTypes = new HashSet<String>();
3131
memberTypes.add(Member.TYPE_MEMBER);
3232
memberTypes.add(Member.TYPE_ADMIN);
3333
memberTypes.add(Member.TYPE_MODERATOR);
3434
MembersList<Member> list = iface.getList(id, memberTypes, 50, 1);
3535
assertNotNull(list);
3636
assertEquals(50, list.size());
37-
Member m = (Member) list.get(10);
37+
Member m = list.get(10);
3838
assertTrue(m.getId().indexOf("@") > 0);
3939
assertTrue(m.getUserName().length() > 0);
4040
assertTrue(m.getIconFarm() > -1);

Flickr4Java/src/test/java/com/flickr4java/flickr/test/PhotosInterfaceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ public void testGetThumbnailImage() throws FlickrException, IOException {
336336
Photo photo = iface.getInfo(photoId, null);
337337
BufferedImage image = iface.getImage(photo, Size.THUMB);
338338
assertNotNull(image);
339-
assertTrue(67 == image.getWidth() || 68 == image.getWidth());
339+
assertTrue(66 == image.getWidth() || 67 == image.getWidth() || 68 == image.getWidth());
340340
assertEquals(100, image.getHeight());
341341
ImageIO.write(image, "jpg", thumbnailFile);
342342
}

0 commit comments

Comments
 (0)