Address API review

Signed-off-by: Andreas Karis <[email protected]>

Author: andreaskaris

apis/v1alpha1/bpf_application_types.go

@@ -31,7 +31,7 @@ type BpfApplicationProgram struct {
 	// name is a required field and is the name of the function that is the entry
 	// point for the eBPF program. name must not be an empty string, must not
 	// exceed 64 characters in length, must start with alpha characters and must
-	// only contain alphanumeric characters.
+	// only contain alphanumeric characters and underscores.
 	// +required
 	// +kubebuilder:validation:Pattern="^[a-zA-Z][a-zA-Z0-9_]+."
 	// +kubebuilder:validation:MinLength=1

apis/v1alpha1/cluster_bpf_application_types.go

@@ -77,7 +77,7 @@ type ClBpfApplicationProgram struct {
 	// name is a required field and is the name of the function that is the entry
 	// point for the eBPF program. name must not be an empty string, must not
 	// exceed 64 characters in length, must start with alpha characters and must
-	// only contain alphanumeric characters.
+	// only contain alphanumeric characters and underscores.
 	// +required
 	// +kubebuilder:validation:Pattern="^[a-zA-Z][a-zA-Z0-9_]+."
 	// +kubebuilder:validation:MinLength=1

apis/v1alpha1/shared_types.go

@@ -53,6 +53,7 @@ type InterfaceDiscovery struct {
 }
 
 // InterfaceSelector describes the set of interfaces to attach a program to.
+// Exactly one of interfacesDiscoveryConfig, interfaces, or primaryNodeInterface must be specified.
 // +kubebuilder:validation:MaxProperties=1
 // +kubebuilder:validation:MinProperties=1
 type InterfaceSelector struct {
@@ -229,6 +230,7 @@ const (
 )
 
 // ByteCodeSelector defines the various ways to reference BPF bytecode objects.
+// Exactly one of image or path must be specified.
 // +kubebuilder:validation:MaxProperties=1
 // +kubebuilder:validation:MinProperties=1
 type ByteCodeSelector struct {
@@ -238,7 +240,7 @@ type ByteCodeSelector struct {
 	Image *ByteCodeImage `json:"image,omitempty"`
 
 	// path is an optional field and used to specify a bytecode object file via
-	// filepath on a Kubernetes node.
+	// filepath on a Kubernetes node. The path must a a valid absolute path.
 	// +optional
 	// +kubebuilder:validation:Pattern=`^(/[^/\0]+)+/?$`
 	Path *string `json:"path,omitempty"`