Skip to content

Commit 53c6694

Browse files
use MSB and LSB data properly in bytes_to_bool unit test, see #36
1 parent 4ab4d1c commit 53c6694

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3838
- Enable reading more than 8 coils in a row, see #36
3939
- Writing multiple coils in TCP, see #22
4040
- Writing multiple registers in TCP, see #23
41+
- Unit test `test_bytes_to_bool` uses MSB and LSB data correctly
4142

4243
## [2.0.0] - 2022-12-03
4344
### Added

tests/test_functions.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -398,23 +398,22 @@ def test_bytes_to_bool(self) -> None:
398398
(b'\x01', 1, [True]),
399399

400400
(b'\x00', 2, [False, False]),
401-
(b'\x01', 2, [True, False]),
402-
(b'\x02', 2, [False, True]),
401+
(b'\x01', 2, [False, True]),
402+
(b'\x02', 2, [True, False]),
403403
(b'\x03', 2, [True, True]),
404404

405405
(b'\x00', 3, [False, False, False]),
406-
(b'\x01', 3, [True, False, False]),
406+
(b'\x01', 3, [False, False, True]),
407407
(b'\x02', 3, [False, True, False]),
408-
(b'\x03', 3, [True, True, False]),
409-
(b'\x04', 3, [False, False, True]),
408+
(b'\x03', 3, [False, True, True]),
409+
(b'\x04', 3, [True, False, False]),
410410
(b'\x05', 3, [True, False, True]),
411-
(b'\x06', 3, [False, True, True]),
411+
(b'\x06', 3, [True, True, False]),
412412
(b'\x07', 3, [True, True, True]),
413413

414414
(b'\x00', 4, [False, False, False, False]),
415-
# (b'\x05', 4, [False, True, False, True]),
416-
(b'\x05', 4, [True, False, True, False]),
417-
(b'\x0A', 4, [False, True, False, True]),
415+
(b'\x05', 4, [False, True, False, True]),
416+
(b'\x0A', 4, [True, False, True, False]),
418417
(b'\x0F', 4, [True, True, True, True]),
419418

420419
(b'\x0A', 5, [False, True, False, True, False]),

0 commit comments

Comments
 (0)