Commit dd06c03
authored
[eval] Eval Viewer Quick Reactions and Comments Dashboard (#8639)
## What
Added Thumbs Up and Thumbs Down reaction toggles for immediate
evaluation rating in the Breadboard Eval Viewer's Topology inspector,
and established a grouped "All Comments" modal to aggregate visual notes
by section.
## Why
Improves evaluation velocity by allowing raters to visually endorse
("Good") or flag ("Bad") individual Node Configurations, Dimensions, and
Transcript events via mutually-exclusive singleton reaction toggles
stored cleanly as `.notes.json` sidecar files.
## Changes
- **Backend & Types (`types.ts`, `filesystem.ts`)**: Expanded `UserNote`
to accommodate optional `.reaction` fields. Added dedicated
`.notes.json` read/write capabilities to `FileSystemEvalBackend`.
- **UI Components (`notes-container.ts`, `bgl-viewer.ts`)**: Built
`<ui-notes-container>` delivering distinct hover-light-up reactivity,
composed bubbling for event delegation, and real-time active state
styles. Incorporated a dashboard for grouping non-reaction notes by
context.
- **State Orchestration (`inspector.ts`)**: Engineered `add-note` and
`delete-note` custom event handlers in `A2UIEvalInspector` enforcing
singleton and mutually-exclusive reaction conditions dynamically on
state updates.
## Testing
- Navigate to the Eval Viewer's Topology mode.
- Click Thumbs Up or Thumbs Down on any configuration item; verify the
corresponding button lights up and replaces opposite reactions.
- Click the lit reaction button again to toggle it OFF.
- Open `.notes.json` to confirm identical state persistence on disk.1 parent 15e4bd6 commit dd06c03
5 files changed
Lines changed: 237 additions & 60 deletions
File tree
- packages/visual-editor/eval/viewer/src
- ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
262 | 262 | | |
263 | 263 | | |
264 | 264 | | |
265 | | - | |
| 265 | + | |
266 | 266 | | |
267 | 267 | | |
268 | 268 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
947 | 947 | | |
948 | 948 | | |
949 | 949 | | |
950 | | - | |
951 | | - | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
952 | 955 | | |
953 | 956 | | |
954 | 957 | | |
955 | 958 | | |
956 | 959 | | |
957 | 960 | | |
| 961 | + | |
958 | 962 | | |
959 | 963 | | |
960 | | - | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
961 | 993 | | |
962 | 994 | | |
963 | 995 | | |
964 | | - | |
| 996 | + | |
| 997 | + | |
965 | 998 | | |
966 | 999 | | |
967 | 1000 | | |
968 | 1001 | | |
969 | 1002 | | |
970 | 1003 | | |
971 | | - | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
972 | 1008 | | |
973 | 1009 | | |
974 | 1010 | | |
975 | 1011 | | |
976 | 1012 | | |
977 | | - | |
| 1013 | + | |
| 1014 | + | |
978 | 1015 | | |
979 | 1016 | | |
980 | 1017 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
989 | 989 | | |
990 | 990 | | |
991 | 991 | | |
992 | | - | |
| 992 | + | |
| 993 | + | |
993 | 994 | | |
994 | 995 | | |
995 | 996 | | |
| |||
1006 | 1007 | | |
1007 | 1008 | | |
1008 | 1009 | | |
1009 | | - | |
| 1010 | + | |
1010 | 1011 | | |
1011 | 1012 | | |
1012 | 1013 | | |
| |||
1017 | 1018 | | |
1018 | 1019 | | |
1019 | 1020 | | |
1020 | | - | |
| 1021 | + | |
1021 | 1022 | | |
1022 | 1023 | | |
1023 | 1024 | | |
| |||
1036 | 1037 | | |
1037 | 1038 | | |
1038 | 1039 | | |
1039 | | - | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
1040 | 1048 | | |
1041 | 1049 | | |
1042 | 1050 | | |
| |||
1076 | 1084 | | |
1077 | 1085 | | |
1078 | 1086 | | |
1079 | | - | |
| 1087 | + | |
1080 | 1088 | | |
1081 | | - | |
| 1089 | + | |
1082 | 1090 | | |
1083 | 1091 | | |
1084 | 1092 | | |
| |||
0 commit comments