Skip to content

Commit 0b2e1ff

Browse files
committed
Addressed comments
1 parent 2e22663 commit 0b2e1ff

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

lib/core/public/load.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@ function runCommand(data, keepalive, callback) {
4242
//a11y-engine iframe rules error merging logic
4343
const errors = a11yEngine.getErrors();
4444
if (Object.keys(errors).length !== 0) {
45-
if (results[results.length - 1].errorsObj) {
45+
if (results[results.length - 1].a11yEngineErrors) {
4646
const error = results.pop();
47-
delete error.errorsObj;
47+
delete error.a11yEngineErrors;
4848
const mergedErrors = mergeErrors(error, errors);
49-
results.push({ ...mergedErrors, errorsObj: true });
49+
results.push({ ...mergedErrors, a11yEngineErrors: true });
5050
} else {
51-
results.push({ ...errors, errorsObj: true });
51+
results.push({ ...errors, a11yEngineErrors: true });
5252
}
5353
}
5454
a11yEngine.clearErrors();

lib/core/public/run-rules.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ export default function runRules(context, options, resolve, reject) {
6565
// after should only run once, so ensure we are in the top level window
6666
if (context.initiator) {
6767
// Return a11y-engine errors when at top level window
68-
if (results[results.length - 1].errorsObj) {
68+
if (results[results.length - 1].a11yEngineErrors) {
6969
const error = results.pop();
70-
delete error.errorsObj;
70+
delete error.a11yEngineErrors;
7171
a11yEngine.mergeErrors(error);
7272
}
7373

lib/core/utils/merge-results.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ function mergeResults(frameResults, options) {
8484
}
8585

8686
const frameSpec = getFrameSpec(frameResult);
87-
if (results[results.length - 1].errorsObj) {
87+
if (results[results.length - 1].a11yEngineErrors) {
8888
const error = results.pop();
89-
delete error.errorsObj;
89+
delete error.a11yEngineErrors;
9090
mergedErrors = mergeErrors(mergedErrors, error, frameSpec);
9191
}
9292

@@ -118,7 +118,7 @@ function mergeResults(frameResults, options) {
118118
if (Object.keys(mergedErrors).length === 0) {
119119
return mergedResult;
120120
}
121-
return [...mergedResult, { ...mergedErrors, errorsObj: true }];
121+
return [...mergedResult, { ...mergedErrors, a11yEngineErrors: true }];
122122
}
123123

124124
function nodeIndexSort(nodeIndexesA = [], nodeIndexesB = []) {

0 commit comments

Comments
 (0)