Merge pull request #102 from bugsnag/next

Release v1.3.3

Author: richardelms

.buildkite/pipeline.full.yml

@@ -21,6 +21,7 @@ steps:
           - features/fixtures/mazerunner/mazerunner_macos_2020.zip
           - features/fixtures/build_macos.log
     commands:
+      - bundle install
       - 'rake test:macos:build'
     retry:
       automatic:
@@ -60,6 +61,7 @@ steps:
           - features/fixtures/mazerunner/mazerunner_macos_2022.zip
           - features/fixtures/build_macos.log
     commands:
+      - bundle install
       - 'rake test:macos:build'
     retry:
       automatic:
@@ -184,6 +186,7 @@ steps:
           - features/fixtures/import_package.log
           - features/fixtures/build_android.log
     commands:
+      - bundle install
       - 'rake test:android:build'
     retry:
       automatic:
@@ -231,6 +234,7 @@ steps:
           - features/fixtures/import_package.log
           - features/fixtures/build_android.log
     commands:
+      - bundle install
       - 'rake test:android:build'
     retry:
       automatic:
@@ -277,6 +281,7 @@ steps:
           - features/fixtures/generateXcodeProject.log
           - project_2020.tgz
     commands:
+      - bundle install
       - 'rake test:ios:generate_xcode'
       - tar -zvcf project_2020.tgz features/fixtures/mazerunner/mazerunner_xcode
     retry:
@@ -299,6 +304,7 @@ steps:
           - features/fixtures/mazerunner/mazerunner_2020.ipa
           - features/fixtures/unity.log
     commands:
+      - bundle install
       - tar -zxf project_2020.tgz features/fixtures/mazerunner
       - 'rake test:ios:build_xcode'
     retry:
@@ -346,6 +352,7 @@ steps:
           - features/fixtures/generateXcodeProject.log
           - project_2022.tgz
     commands:
+      - bundle install
       - 'rake test:ios:generate_xcode'
       - tar -zvcf project_2022.tgz features/fixtures/mazerunner/mazerunner_xcode
     retry:
@@ -368,6 +375,7 @@ steps:
           - features/fixtures/mazerunner/mazerunner_2022.ipa
           - features/fixtures/unity.log
     commands:
+      - bundle install
       - tar -zxf project_2022.tgz features/fixtures/mazerunner
       - 'rake test:ios:build_xcode'
     retry:

.buildkite/pipeline.yml

@@ -50,6 +50,7 @@ steps:
           - features/fixtures/mazerunner/mazerunner_webgl_2021.zip
           - features/fixtures/build_webgl.log
     commands:
+      - bundle install
       - 'rake test:webgl:build'
     retry:
       automatic:
@@ -132,6 +133,7 @@ steps:
           - features/fixtures/mazerunner/mazerunner_macos_2021.zip
           - features/fixtures/build_macos.log
     commands:
+      - bundle install
       - 'rake test:macos:build'
     retry:
       automatic:
@@ -172,6 +174,7 @@ steps:
           - features/fixtures/import_package.log
           - features/fixtures/build_android.log
     commands:
+      - bundle install
       - 'rake test:android:build'
     retry:
       automatic:
@@ -218,6 +221,7 @@ steps:
           - features/fixtures/generateXcodeProject.log
           - project_2021.tgz
     commands:
+      - bundle install
       - 'rake test:ios:generate_xcode'
       - tar -zvcf project_2021.tgz features/fixtures/mazerunner/mazerunner_xcode
     retry:
@@ -240,6 +244,7 @@ steps:
           - features/fixtures/mazerunner/mazerunner_2021.ipa
           - features/fixtures/unity.log
     commands:
+      - bundle install
       - tar -zxf project_2021.tgz features/fixtures/mazerunner
       - 'rake test:ios:build_xcode'
     retry:

BugsnagPerformance/Assets/BugsnagPerformance/Scripts/Internal/Delivery.cs

@@ -173,7 +173,7 @@ private static double ReadResponseProbability(UnityWebRequest req)
                 var probabilityStr = req.GetResponseHeader("Bugsnag-Sampling-Probability");
                 if (probabilityStr != null)
                 {
-                    return Convert.ToDouble(probabilityStr);
+                    return double.Parse(probabilityStr, CultureInfo.InvariantCulture);
                 }
             }
             catch

BugsnagPerformance/Assets/BugsnagPerformance/Scripts/Internal/TracePayload.cs

@@ -4,6 +4,7 @@
 using System.Text;
 using Newtonsoft.Json;
 using System.Linq;
+using System.Globalization;
 
 namespace BugsnagUnityPerformance
 {
@@ -136,9 +137,9 @@ private static string BuildSamplingHistogramHeader(TracePayload payload)
 
             foreach (KeyValuePair<double, int> pair in payload.SamplingHistogram)
             {
-                builder.Append(pair.Key);
+                builder.Append(pair.Key.ToString(CultureInfo.InvariantCulture));
                 builder.Append(':');
-                builder.Append(pair.Value);
+                builder.Append(pair.Value.ToString(CultureInfo.InvariantCulture));
                 builder.Append(';');
             }
             builder.Remove(builder.Length - 1, 1);

BugsnagPerformance/Assets/BugsnagPerformance/Scripts/Internal/Version.cs

@@ -3,6 +3,6 @@
     internal static class Version
     {
         //TODO set this using sed or something in the release automation task
-        public const string VersionString = "1.3.2";
+        public const string VersionString = "1.3.3";
     }
 }

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## v1.3.3 (2024-03-07)
+
+### Bug Fixes
+
+- Fixed issue where the p value header was being parsed without specific formatting instructions, meaning that when running in different locals, it could be parsed incorrectly. [#101](https://github.com/bugsnag/bugsnag-unity-performance/pull/101)
+
 ## v1.3.2 (2024-14-02)
 
 ### Bug Fixes

features/persistence.feature

@@ -127,3 +127,11 @@ Feature: Trace and state persistence
     # And I wait to receive a sampling request
     # And I discard the oldest sampling request
     # And I wait to receive a sampling request
+
+  @skip_webgl #Pending PLAT-8151
+  Scenario: P value response parsing
+    Given I set the sampling probability for the next traces to "0.9999999"
+    And I run the game in the "PValueUpdate" state
+    And I wait to receive a sampling request
+    And I wait for 1 span
+    And the trace payload field "resourceSpans.0.scopeSpans.0.spans.0.attributes.2.value.doubleValue" equals 0.9999999