Merge pull request #118 from bugsnag/next

Release v1.4.1

Author: richardelms

BugsnagPerformance/Assets/BugsnagPerformance/Scripts/Internal/SpanFactory.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Security.Cryptography;
 using BugsnagNetworking;
@@ -16,9 +17,18 @@ internal class SpanFactory
 
         private OnSpanEnd _onSpanEnd;
 
+        private const string CONNECTION_TYPE_UNAVAILABLE = "unavailable";
+        private const string CONNECTION_TYPE_CELL = "cell";
+        private const string CONNECTION_TYPE_WIFI = "wifi";
+    
+        private string _currentConnectionType = CONNECTION_TYPE_UNAVAILABLE;
+
+        private WaitForSeconds _connectionPollRate = new WaitForSeconds(1);
+
         public SpanFactory(OnSpanEnd onSpanEnd)
         {
             _onSpanEnd = onSpanEnd;
+            MainThreadDispatchBehaviour.Instance().StartCoroutine(GetConnectionType());
         }
 
         private string GetNewTraceId()
@@ -89,7 +99,7 @@ private Span CreateSpan(string name, SpanKind kind, SpanOptions spanOptions)
             {
                 AddToContextStack(newSpan);
             }
-            newSpan.SetAttribute("net.host.connection.type", GetConnectionType());
+            newSpan.SetAttribute("net.host.connection.type",_currentConnectionType);
             return newSpan;
         }
 
@@ -128,18 +138,24 @@ internal Span CreateManualNetworkSpan(string url, HttpVerb httpVerb, SpanOptions
             return span;
         }
 
-        private string GetConnectionType()
+        private IEnumerator GetConnectionType()
         {
-            switch (Application.internetReachability)
+            while(true)
             {
-                case NetworkReachability.NotReachable:
-                    return "unavailable";
-                case NetworkReachability.ReachableViaCarrierDataNetwork:
-                    return "cell";
-                case NetworkReachability.ReachableViaLocalAreaNetwork:
-                    return "wifi";
-                default:
-                    return string.Empty;
+                switch (Application.internetReachability)
+                {
+                    case NetworkReachability.NotReachable:
+                        _currentConnectionType = CONNECTION_TYPE_UNAVAILABLE;
+                        break;
+                    case NetworkReachability.ReachableViaCarrierDataNetwork:
+                        _currentConnectionType = CONNECTION_TYPE_CELL;
+                        break;
+                    case NetworkReachability.ReachableViaLocalAreaNetwork:
+                        _currentConnectionType = CONNECTION_TYPE_WIFI;
+                        break;
+
+                }
+                yield return _connectionPollRate;
             }
         }
 

BugsnagPerformance/Assets/BugsnagPerformance/Scripts/Internal/Version.cs

@@ -3,6 +3,6 @@
     internal static class Version
     {
         //TODO set this using sed or something in the release automation task
-        public const string VersionString = "1.4.0";
+        public const string VersionString = "1.4.1";
     }
 }

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## v1.4.1 (2024-11-06)
+
+### Bug Fixes
+
+- Fixed issue where creating a span in a background thread caused an exception (mono or IL2CPP Dev builds only) [#117](https://github.com/bugsnag/bugsnag-unity-performance/pull/117)
+
 ## v1.4.0 (2024-30-05)
 
 ### Additions