correct capitalization

Author: sluongng

server/util/proto/proto.go

@@ -20,7 +20,7 @@ var Bool = gproto.Bool
 type Message = gproto.Message
 type MarshalOptions = gproto.MarshalOptions
 
-type VtprotoMessage interface {
+type VTProtoMessage interface {
 	MarshalVT() ([]byte, error)
 	UnmarshalVT([]byte) error
 	CloneMessageVT() Message
@@ -31,15 +31,15 @@ type VtprotoMessage interface {
 }
 
 func Marshal(v Message) ([]byte, error) {
-	vt, ok := v.(VtprotoMessage)
+	vt, ok := v.(VTProtoMessage)
 	if ok {
 		return vt.MarshalVT()
 	}
 	return MarshalOld(v)
 }
 
 func Unmarshal(b []byte, v Message) error {
-	vt, ok := v.(VtprotoMessage)
+	vt, ok := v.(VTProtoMessage)
 	if ok {
 		return vt.UnmarshalVT(b)
 	}
@@ -48,7 +48,7 @@ func Unmarshal(b []byte, v Message) error {
 }
 
 func Clone(v Message) Message {
-	vt, ok := v.(VtprotoMessage)
+	vt, ok := v.(VTProtoMessage)
 	if ok {
 		return vt.CloneMessageVT()
 	}

server/util/vtprotocodec/vtprotocodec.go

@@ -11,48 +11,48 @@ import (
 
 const Name = "proto"
 
-// vtprotoCodecV2 implements encoding.CodecV2 and uses vtproto and default buffer pool
+// CodecV2 implements encoding.CodecV2 and uses vtproto and default buffer pool
 // to encode/decode proto messages. The implementation is heavily inspired by
 // https://github.com/planetscale/vtprotobuf/pull/138
 // and https://github.com/vitessio/vitess/pull/16790.
-type vtprotoCodecV2 struct {
+type CodecV2 struct {
 	fallback encoding.CodecV2
 }
 
-func (vtprotoCodecV2) Name() string {
+func (CodecV2) Name() string {
 	return Name
 }
 
-func (c *vtprotoCodecV2) Marshal(v any) (mem.BufferSlice, error) {
-	m, ok := v.(proto.VtprotoMessage)
+func (c *CodecV2) Marshal(v any) (mem.BufferSlice, error) {
+	m, ok := v.(proto.VTProtoMessage)
 	if !ok {
 		return c.fallback.Marshal(v)
 	}
-
 	size := m.SizeVT()
 	if mem.IsBelowBufferPoolingThreshold(size) {
-		buf := make([]byte, 0, size)
-		if _, err := m.MarshalToSizedBufferVT(buf[:size]); err != nil {
+		buf := make([]byte, size)
+		n, err := m.MarshalToSizedBufferVT(buf)
+		if err != nil {
 			return nil, err
 		}
-		return mem.BufferSlice{mem.SliceBuffer(buf)}, nil
+		return mem.BufferSlice{mem.SliceBuffer(buf[:n])}, nil
 	}
-
 	pool := mem.DefaultBufferPool()
 	buf := pool.Get(size)
-	if _, err := m.MarshalToSizedBufferVT((*buf)[:size]); err != nil {
+	n, err := m.MarshalToSizedBufferVT(*buf)
+	if err != nil {
 		pool.Put(buf)
 		return nil, err
 	}
+	*buf = (*buf)[:n]
 	return mem.BufferSlice{mem.NewBuffer(buf, pool)}, nil
 }
 
-func (c *vtprotoCodecV2) Unmarshal(data mem.BufferSlice, v any) error {
-	m, ok := v.(proto.VtprotoMessage)
+func (c *CodecV2) Unmarshal(data mem.BufferSlice, v any) error {
+	m, ok := v.(proto.VTProtoMessage)
 	if !ok {
 		return c.fallback.Unmarshal(data, v)
 	}
-
 	buf := data.MaterializeToBuffer(mem.DefaultBufferPool())
 	defer buf.Free()
 	return m.UnmarshalVT(buf.ReadOnlyData())
@@ -61,7 +61,8 @@ func (c *vtprotoCodecV2) Unmarshal(data mem.BufferSlice, v any) error {
 // RegisterCodec registers the vtprotoCodec to encode/decode proto messages with
 // all gRPC clients and servers.
 func Register() {
-	encoding.RegisterCodecV2(&vtprotoCodecV2{
+	encoding.RegisterCodecV2(&CodecV2{
+		// the default codecv2 implemented in @org_golang_google_grpc//encoding/proto.
 		fallback: encoding.GetCodecV2("proto"),
 	})
 }