Skip to content

Commit 5cf3a3e

Browse files
author
Konstantin Yakushev
committed
Add comments for nulls and create a constant. (#11)
1 parent d89558b commit 5cf3a3e

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

src/main/java/com/bunq/tinker/LinkCard.java

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,15 @@
88
import com.bunq.tinker.utils.ITinker;
99
import org.apache.commons.cli.CommandLine;
1010
import org.apache.commons.cli.ParseException;
11-
1211
import java.util.ArrayList;
13-
import java.util.List;
1412

1513
public class LinkCard implements ITinker {
1614

15+
/**
16+
* Input constants.
17+
*/
18+
private static final String CARD_PIN_ASSIGNMENT_TYPE_PRIMARY = "PRIMARY";
19+
1720
/**
1821
* @param args
1922
*
@@ -31,7 +34,11 @@ public void run(String[] args) throws ParseException {
3134
String cardId = SharedLib.determineCardIdFromAllOptionOrStdIn(allOption);
3235
String accountId = SharedLib.determineAccountIdFromAllOptionOrStdIn(allOption);
3336

34-
allCardPinAssignment.add(new CardPinAssignment("PRIMARY",null, Integer.parseInt(accountId)));
37+
allCardPinAssignment.add(new CardPinAssignment(
38+
CARD_PIN_ASSIGNMENT_TYPE_PRIMARY,
39+
null, /* pinCode */
40+
Integer.parseInt(accountId))
41+
);
3542

3643
System.out.println();
3744
System.out.println(" | Link Card: " + cardId);
@@ -45,12 +52,11 @@ public void run(String[] args) throws ParseException {
4552
null, /* pinCode */
4653
null, /* activationCode */
4754
null, /* status */
48-
null, /* limit */
55+
null, /* cardLimit */
56+
null, /* cardLimitAtm */
4957
null, /* magStripePermissions */
5058
null, /* countryPermission */
51-
null,
52-
allCardPinAssignment,
53-
null
59+
allCardPinAssignment
5460
);
5561

5662
System.out.println();

0 commit comments

Comments
 (0)