2867 - typecheck. this probably needs to be looked into and changed!!!

Author: marko-kriskovic

client/src/pages/platform/workflow-editor/utils/clusterElementsFieldChangeUtils.ts

@@ -12,7 +12,13 @@ type FieldUpdateType = {
 interface CreateUpdatedElementProps {
     currentComponentDefinition: ComponentDefinition;
     currentOperationProperties?: Array<PropertyAllType>;
-    element: ClusterElementItemType | NodeDataType;
+    element:
+        | ClusterElementItemType
+        | NodeDataType
+        | (Omit<NodeDataType, 'componentName' | 'workflowNodeName'> & {
+              componentName?: string;
+              workflowNodeName?: string;
+          });
     fieldUpdate: FieldUpdateType;
 }
 
@@ -59,7 +65,10 @@ interface UpdateClusterRootElementFieldProps {
     currentComponentDefinition: ComponentDefinition;
     currentOperationProperties?: Array<PropertyAllType>;
     fieldUpdate: FieldUpdateType;
-    mainRootElement: NodeDataType;
+    mainRootElement: Omit<NodeDataType, 'componentName' | 'workflowNodeName'> & {
+        componentName?: string;
+        workflowNodeName?: string;
+    };
 }
 
 export function updateClusterRootElementField({
@@ -78,9 +87,9 @@ export function updateClusterRootElementField({
     return {
         ...mainRootElement,
         ...updatedElementData,
-        componentName: mainRootElement.componentName,
+        ...(mainRootElement.componentName ? {componentName: mainRootElement.componentName} : {}),
         name: mainRootElement.name,
-        workflowNodeName: mainRootElement.workflowNodeName,
+        ...(mainRootElement.workflowNodeName ? {workflowNodeName: mainRootElement.workflowNodeName} : {}),
     };
 }
 

client/src/pages/platform/workflow-editor/utils/handleComponentAddedSuccess.ts

@@ -2,11 +2,14 @@ import useWorkflowNodeDetailsPanelStore from '@/pages/platform/workflow-editor/s
 import {Workflow} from '@/shared/middleware/platform/configuration';
 import {WorkflowNodeOutputKeys} from '@/shared/queries/platform/workflowNodeOutputs.queries';
 import {environmentStore} from '@/shared/stores/useEnvironmentStore';
-import {NodeDataType} from '@/shared/types';
+import {ComponentType, NodeDataType} from '@/shared/types';
 import {QueryClient} from '@tanstack/react-query';
 
 interface HandleComponentAddedSuccessProps {
-    nodeData: NodeDataType;
+    nodeData: Omit<NodeDataType, 'componentName' | 'workflowNodeName'> & {
+        componentName?: string;
+        workflowNodeName?: string;
+    };
     queryClient: QueryClient;
     workflow: Workflow;
 }
@@ -33,12 +36,12 @@ export default function handleComponentAddedSuccess({
 
     if (useWorkflowNodeDetailsPanelStore.getState().workflowNodeDetailsPanelOpen) {
         if (currentNode?.trigger && nodeData.trigger) {
-            setCurrentNode({...currentNode, ...nodeData});
-            setCurrentComponent({...currentComponent, ...nodeData});
+            setCurrentNode({...currentNode, ...nodeData} as NodeDataType);
+            setCurrentComponent({...currentComponent, ...nodeData} as ComponentType);
         }
     } else if (!nodeData.clusterElements) {
-        setCurrentNode({...nodeData, description: ''});
-        setCurrentComponent({...nodeData, description: ''});
+        setCurrentNode({...nodeData, description: ''} as NodeDataType);
+        setCurrentComponent({...nodeData, description: ''} as ComponentType);
         setWorkflowNodeDetailsPanelOpen(true);
     }
 }

client/src/pages/platform/workflow-editor/utils/saveClusterElementFieldChange.ts

@@ -1,5 +1,5 @@
 import {ComponentDefinition, Workflow} from '@/shared/middleware/platform/configuration';
-import {ClusterElementsType, NodeDataType, PropertyAllType} from '@/shared/types';
+import {ClusterElementsType, ComponentType, NodeDataType, PropertyAllType} from '@/shared/types';
 import {UseMutationResult} from '@tanstack/react-query';
 
 import useWorkflowDataStore from '../stores/useWorkflowDataStore';
@@ -49,15 +49,15 @@ export default function saveClusterElementFieldChange({
               tasks: workflowDefinitionTasks,
           })
         : undefined;
-    // const mainClusterRootTask = workflowDefinitionTasks?.find(
-    //     (task: {name: string}) => task.name === rootClusterElementNodeData?.workflowNodeName
-    // );
 
     if (!mainClusterRootTask) {
         return;
     }
 
-    let updatedMainRootData: NodeDataType;
+    let updatedMainRootData: Omit<NodeDataType, 'componentName' | 'workflowNodeName'> & {
+        componentName?: string;
+        workflowNodeName?: string;
+    };
     let updatedClusterElements: ClusterElementsType;
 
     if (
@@ -104,7 +104,11 @@ export default function saveClusterElementFieldChange({
         invalidateWorkflowQueries,
         nodeData: updatedMainRootData,
         onSuccess: () => {
-            let commonUpdates: NodeDataType = {
+            let commonUpdates: Omit<NodeDataType, 'componentName' | 'workflowNodeName'> & {
+                componentName?: string;
+                name: string;
+                workflowNodeName?: string;
+            } = {
                 componentName,
                 name,
                 workflowNodeName,
@@ -134,12 +138,12 @@ export default function saveClusterElementFieldChange({
             setCurrentNode({
                 ...currentNode,
                 ...commonUpdates,
-            });
+            } as NodeDataType);
 
             setCurrentComponent({
                 ...currentComponent,
                 ...commonUpdates,
-            });
+            } as ComponentType);
 
             if (rootClusterElementNodeData) {
                 if (currentNode.clusterRoot && !currentNode.isNestedClusterRoot) {

client/src/pages/platform/workflow-editor/utils/saveWorkflowDefinition.ts

@@ -17,7 +17,10 @@ type UpdateWorkflowRequestType = {
 interface SaveWorkflowDefinitionProps {
     decorative?: boolean;
     invalidateWorkflowQueries: () => void;
-    nodeData?: NodeDataType;
+    nodeData?: Omit<NodeDataType, 'componentName' | 'workflowNodeName'> & {
+        componentName?: string;
+        workflowNodeName?: string;
+    };
     nodeIndex?: number;
     onSuccess?: () => void;
     placeholderId?: string;