Skip to content

Fix Github action compatibility and linter issues #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2025
Merged

Fix Github action compatibility and linter issues #11

merged 4 commits into from
Aug 21, 2025

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented Aug 21, 2025 •
edited
Loading

What changed?

  • Fixed generate_proto.py Linux compatibility
  • Resolved linter violations in decision_state_machine.py by cleaning up unused imports
  • Simplified protobuf include path handling for cross-platform consistency

Why?
The script had hardcoded macOS paths that failed on Linux CI, and linter was failing due to unused imports.

How did you test it?

  • Local linter passes: uv tool run ruff check
  • CI workflow now passes successfully

Potential risks

Release notes

Documentation Changes

@timl3136 timl3136 changed the title try to fix linter Fix Github action compatibility and linter issues Aug 21, 2025
@timl3136 timl3136 merged commit 4e16d4a into cadence-workflow:main Aug 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shijiesheng shijiesheng shijiesheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timl3136 @shijiesheng