feat: unify approach to expo-updates, downstream from #360

Author: artus9033

gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/plugin/RNSourceSets.kt

@@ -55,25 +55,33 @@ object RNSourceSets {
                     isDebuggable = variant.debuggable,
                 )
             val capitalizedBundledAssetsVariantName = bundledAssetsVariantName.capitalized()
+            val appProject = getAppProject()
 
             // 3. Lazily configure the 'variant-specific' source set using .named()
             androidExtension.sourceSets.named(variantName) { sourceSet ->
-                // Paths are collected and added, similar to your improved version
                 val bundlePathSegments =
                     listOf(
                         // outputs for RN <= 0.81
                         "createBundle${capitalizedBundledAssetsVariantName}JsAndAssets",
                         // outputs for RN >= 0.82
                         "react/$bundledAssetsVariantName",
-                        // expo update resources
-                        "create${capitalizedBundledAssetsVariantName}UpdatesResources",
                     )
+                val updateResourcesPathSegment = Utils.getExpoUpdatesResourcesTaskName(variant.name)
 
                 // Add the variant-specific generated asset and resource directories
                 val appBuildDir = getAppBuildDir()
                 sourceSet.assets.srcDirs(bundlePathSegments.map { "$appBuildDir/generated/assets/$it" })
                 sourceSet.res.srcDirs(bundlePathSegments.map { "$appBuildDir/generated/res/$it" })
                 sourceSet.jniLibs.srcDirs("libs${variantName.capitalized()}")
+                if (Utils.hasExpoUpdates(appProject, variant.name)) {
+                    val updateResourcesTask = appProject.tasks.named(updateResourcesPathSegment)
+                    sourceSet.assets.srcDir(
+                        project.files("$appBuildDir/generated/assets/$updateResourcesPathSegment").builtBy(updateResourcesTask),
+                    )
+                    sourceSet.res.srcDir(
+                        project.files("$appBuildDir/generated/res/$updateResourcesPathSegment").builtBy(updateResourcesTask),
+                    )
+                }
             }
         }
     }

gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/VariantTaskProvider.kt

@@ -95,13 +95,9 @@ class VariantTaskProvider(val project: Project) {
         preBuildTask.dependsOn("${appProject.path}:createBundle${capitalizedBundledAssetsVariantName}JsAndAssets")
 
         if (Utils.isExpoProject(project)) {
-            val updatesResourcesTaskName =
-                "create${capitalizedBundledAssetsVariantName}UpdatesResources"
-
-            appProject.tasks
-            .matching { it.name == updatesResourcesTaskName }
-            .configureEach { updatesTask ->
-                preBuildTask.dependsOn(updatesTask)
+            val updatesResourcesTaskName = Utils.getExpoUpdatesResourcesTaskName(variantName)
+            if (Utils.hasExpoUpdates(appProject, variantName)) {
+                preBuildTask.dependsOn("${appProject.path}:$updatesResourcesTaskName")
             }
         }
     }

gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/utils/Utils.kt

@@ -28,6 +28,20 @@ object Utils {
         return project.findProject(EXPO_PROJECT_LOCATOR) != null
     }
 
+    fun getExpoUpdatesResourcesTaskName(variantName: String): String {
+        return "create${variantName.capitalized()}UpdatesResources"
+    }
+
+    fun hasExpoUpdates(
+        project: Project,
+        variantName: String,
+    ): Boolean {
+        return isExpoProject(project) &&
+            project.tasks.names.contains(
+                getExpoUpdatesResourcesTaskName(variantName),
+            )
+    }
+
     fun getBundledAssetsVariantName(
         variantName: String?,
         buildTypeName: String?,