From 36788b12974d01de85f99942633db225382eabac Mon Sep 17 00:00:00 2001 From: Andrew <35735666+meatnordrink@users.noreply.github.com> Date: Wed, 23 Jul 2025 10:01:38 -0400 Subject: [PATCH 1/2] docs: Update TouchableRipple.tsx to note a11y considerations --- src/components/TouchableRipple/TouchableRipple.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/components/TouchableRipple/TouchableRipple.tsx b/src/components/TouchableRipple/TouchableRipple.tsx index ecf848da32..4d3943e48a 100644 --- a/src/components/TouchableRipple/TouchableRipple.tsx +++ b/src/components/TouchableRipple/TouchableRipple.tsx @@ -101,6 +101,10 @@ export type Props = PressableProps & { * export default MyComponent; * ``` * + * ### Accessibility + * Note that, while `onPress` is not a required prop, not passing an `onPress` prop directly to `TouchableRipple` (e.g., passing it to a component it wraps instead) will likely break the accessibility of the component. + * When `onPress` is not present, the component will read as a "dimmed", inactive button to screen readers, and will not be reachable at all to voice control users. + * * @extends Pressable props https://reactnative.dev/docs/Pressable#props */ const TouchableRipple = ( From c7012e896b32fde09b9a807fac0fb42ddfe2ad7a Mon Sep 17 00:00:00 2001 From: Andrew <35735666+meatnordrink@users.noreply.github.com> Date: Thu, 24 Jul 2025 12:22:44 -0400 Subject: [PATCH 2/2] docs: removing extra space per linter --- src/components/TouchableRipple/TouchableRipple.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/TouchableRipple/TouchableRipple.tsx b/src/components/TouchableRipple/TouchableRipple.tsx index 4d3943e48a..ee2a03f178 100644 --- a/src/components/TouchableRipple/TouchableRipple.tsx +++ b/src/components/TouchableRipple/TouchableRipple.tsx @@ -104,7 +104,7 @@ export type Props = PressableProps & { * ### Accessibility * Note that, while `onPress` is not a required prop, not passing an `onPress` prop directly to `TouchableRipple` (e.g., passing it to a component it wraps instead) will likely break the accessibility of the component. * When `onPress` is not present, the component will read as a "dimmed", inactive button to screen readers, and will not be reachable at all to voice control users. - * + * * @extends Pressable props https://reactnative.dev/docs/Pressable#props */ const TouchableRipple = (