-
Notifications
You must be signed in to change notification settings - Fork 31
Open
Description
Describe the feature
Support signing *.aab files via the sign:android command.
Motivation
Rock currently supports signing APKs, but not AABs. Since these are required for release and test distribution via Play Store, and supported by e2e testing platforms (saucelabs, browserstach etc.), it'd seem like a good extension of the android platform plugin.
Related Issues
No related issues found.
Planning to open a PR later this week, but interested in feedback on command API changes or implementation details. From initial testing, we'd just need to:
- allow sign:android to accept both bundles and apk,
- use a different path as js bundle replacement destination
- use a different signer (jarsigner, not available in build-tools)
Since this isn't switching too much on aab vs apk, I'd just extend signAndroid.ts with necessary checks for file paths, separate signAabFile vs signApkFile commands.
Metadata
Metadata
Assignees
Labels
No labels