Skip to content

Commit e4890fd

Browse files
committed
improve wording
1 parent bdc20a8 commit e4890fd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

examples/middleware-roundtripper/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44

55
The purpose of this example is to demonstrate a few common usecases for HTTP server middlewares and client-side round trippers.
66

7-
It provides wrapper types to string together nested/sequential middlewares and roundtrippers. This makes it easy to show how different orders affect the effectiveness of these functions.
7+
It provides wrapper types to string together nested/sequential middlewares and roundtrippers. This makes it easy to show how different ordering impacts the effectiveness of these functions.
88

99
I encourage you to take a look at the tests which will demonstrate the different correct and incorrect uses of these.
1010

1111
Some incorrect uses aren't shown, like running a middleware that could panic before applying the RecoverMiddleware.
1212

13-
- If logging or caching middleware is applied before sanitizing auth details, the auth details are logged/cached
13+
- If caching middleware is applied before sanitizing auth details, the auth details are cached
1414
- If the logging or caching round tripper runs after applying auth to the request, the auth details are logged/cached
1515
- If a server-side cache middleware is used before checking authentication, responses could be leaked to unauthorized requests

0 commit comments

Comments
 (0)