Merge pull request #144 from canjs/default-value-setter-infinite-loop

Default value setter infinite loop

Author: phillipskevin

.travis.yml

@@ -3,4 +3,6 @@ language: node_js
 node_js: node
 before_install:
   - "export DISPLAY=:99.0"
-  - "sh -e /etc/init.d/xvfb start"
+  - "sh -e /etc/init.d/xvfb start"
+addons:
+  firefox: "latest"

can-define.js

@@ -626,6 +626,10 @@ replaceWith = function(obj, prop, cb, writable) {
 	Object.defineProperty(obj, prop, {
 		configurable: true,
 		get: function() {
+			Object.defineProperty(this, prop, {
+				value: undefined,
+				writable: true
+			});
 			var value = cb.call(this, obj, prop);
 			Object.defineProperty(this, prop, {
 				value: value,

define-test.js

@@ -1489,3 +1489,18 @@ QUnit.test("async setter is provided", 5, function(){
 	QUnit.equal(instance.prop2, 9, "used async setter updates after");
 
 });
+
+QUnit.test('setter with default value causes an infinite loop (#142)', function(){
+	var A = define.Constructor({
+		val: {
+			value: 'hello',
+			set: function(val){
+				if(this.val) {}
+				return val;
+			}
+		}
+	});
+
+	var a = new A();
+	QUnit.equal(a.val, 'hello', 'creating an instance should not cause an inifinte loop');
+});