Tms32c64x Little Endian (#2648)

* Add little endian support for TMS320c64x.
This requires now to initialize TMS320c64x with the
CS_MODE_BIG_ENDIAN flag.

* Fix typo

Author: Rot127

arch/TMS320C64x/TMS320C64xDisassembler.c

@@ -600,7 +600,7 @@ bool TMS320C64x_getInstruction(csh ud, const uint8_t *code, size_t code_len,
 	if(MI->flat_insn->detail)
 		memset(MI->flat_insn->detail, 0, offsetof(cs_detail, tms320c64x)+sizeof(cs_tms320c64x));
 
-	insn = (code[3] << 0) | (code[2] << 8) | (code[1] << 16) | ((uint32_t) code[0] << 24);
+	insn = readBytes32(MI, code);
 	result = decodeInstruction_4(DecoderTable32, MI, insn, address, info, 0);
 
 	if(result == MCDisassembler_Success) {

arch/TMS320C64x/TMS320C64xInstPrinter.c

@@ -62,8 +62,8 @@ void TMS320C64x_post_printer(csh ud, cs_insn *insn, SStream *insn_asm, MCInst *m
 			SStream_concat(&ss, "[%c%s]|", (tms320c64x->condition.zero == 1) ? '!' : '|', cs_reg_name(ud, tms320c64x->condition.reg));
 
 		// Sorry for all the fixes below. I don't have time to add more helper SStream functions.
-		// Before that they messed around with the private buffer of th stream.
-		// So it is better now. But still not effecient.
+		// Before that they messed around with the private buffer of the stream.
+		// So it is better now. But still not efficient.
 		op_str_ptr = strchr(SStream_rbuf(insn_asm), '\t');
 
 		if ((op_str_ptr != NULL) && (((p2 = strchr(op_str_ptr, '[')) != NULL) || ((p2 = strchr(op_str_ptr, '(')) != NULL))) {

arch/TMS320C64x/TMS320C64xModule.c

@@ -33,6 +33,16 @@ cs_err TMS320C64x_global_init(cs_struct *ud)
 
 cs_err TMS320C64x_option(cs_struct *handle, cs_opt_type type, size_t value)
 {
+	switch (type) {
+	case CS_OPT_MODE:
+		handle->mode |= (cs_mode)value;
+		break;
+	case CS_OPT_SYNTAX:
+		handle->syntax |= (int)value;
+		break;
+	default:
+		break;
+	}
 	return CS_ERR_OK;
 }
 

cs.c

@@ -188,7 +188,7 @@ typedef struct cs_arch_config {
 	{ \
 		TMS320C64x_global_init, \
 		TMS320C64x_option, \
-		~(CS_MODE_BIG_ENDIAN), \
+		~(CS_MODE_LITTLE_ENDIAN | CS_MODE_BIG_ENDIAN), \
 	}
 #define CS_ARCH_CONFIG_M680X \
 	{ \

cstool/cstool.c

@@ -178,6 +178,7 @@ static struct {
 	{ "m68k40", "m68k40", CS_ARCH_M68K, CS_MODE_M68K_040 },
 
 	{ "tms320c64x", "tms320c64x, big endian", CS_ARCH_TMS320C64X, CS_MODE_BIG_ENDIAN },
+	{ "tms320c64xle", "tms320c64x, little endian", CS_ARCH_TMS320C64X, CS_MODE_LITTLE_ENDIAN },
 
 	{ "m6800", "m680x, M6800/2", CS_ARCH_M680X, CS_MODE_M680X_6800 },
 	{ "m6801", "m680x, M6801/3", CS_ARCH_M680X, CS_MODE_M680X_6801 },

tests/details/tms320c64x.yaml

@@ -3,7 +3,7 @@ test_cases:
     input:
       bytes: [ 0x01, 0xac, 0x88, 0x40, 0x81, 0xac, 0x88, 0x43, 0x00, 0x00, 0x00, 0x00, 0x02, 0x90, 0x32, 0x96, 0x02, 0x80, 0x46, 0x9e, 0x05, 0x3c, 0x83, 0xe6, 0x0b, 0x0c, 0x8b, 0x24  ]
       arch: "tms320c64x"
-      options: [ CS_OPT_DETAIL ]
+      options: [ CS_OPT_DETAIL, CS_MODE_BIG_ENDIAN ]
       address: 0x1000
     expected:
       insns:
@@ -144,4 +144,48 @@ test_cases:
             funit_side_set: true
             parallel: 0
             parallel_set: true
+  -
+    input:
+      bytes: [ 0xa9, 0xff, 0x7f, 0x02 ]
+      name: "Little/big endian test"
+      arch: "tms320c64x"
+      options: [ CS_OPT_DETAIL, CS_MODE_LITTLE_ENDIAN ]
+      address: 0x1000
+    expected:
+      insns:
+      -
+        asm_text: "mvk.S1	-1, a4	||"
+  -
+    input:
+      bytes: [ 0x02, 0x7f, 0xff, 0xa9 ]
+      name: "Little/big endian test"
+      arch: "tms320c64x"
+      options: [ CS_OPT_DETAIL, CS_MODE_BIG_ENDIAN ]
+      address: 0x1000
+    expected:
+      insns:
+      -
+        asm_text: "mvk.S1	-1, a4	||"
+  -
+    input:
+      bytes: [ 0xa9, 0xff, 0x7f, 0x02 ]
+      name: "Little/big endian test no detail fixup."
+      arch: "tms320c64x"
+      options: [ CS_MODE_LITTLE_ENDIAN ]
+      address: 0x1000
+    expected:
+      insns:
+      -
+        asm_text: "mvk -1, a4"
+  -
+    input:
+      bytes: [ 0x02, 0x7f, 0xff, 0xa9 ]
+      name: "Little/big endian test no detail fixup"
+      arch: "tms320c64x"
+      options: [ CS_MODE_BIG_ENDIAN ]
+      address: 0x1000
+    expected:
+      insns:
+      -
+        asm_text: "mvk -1, a4"