From bf27aba10b7c204f8d5632d1bbea707280e0453d Mon Sep 17 00:00:00 2001 From: Matt Gallo Date: Tue, 30 Sep 2025 16:20:16 -0400 Subject: [PATCH] fix(storybook): add a11y checker back, react/wc --- .../.storybook/main.ts | 2 + .../ibm-products-web-components/package.json | 10 +- packages/ibm-products/.storybook/main.js | 4 +- packages/ibm-products/package.json | 10 +- yarn.lock | 179 +++++++++++------- 5 files changed, 124 insertions(+), 81 deletions(-) diff --git a/packages/ibm-products-web-components/.storybook/main.ts b/packages/ibm-products-web-components/.storybook/main.ts index 758e0649652..ac10d075602 100644 --- a/packages/ibm-products-web-components/.storybook/main.ts +++ b/packages/ibm-products-web-components/.storybook/main.ts @@ -19,6 +19,8 @@ const stories = glob.sync( const config = { stories: stories, addons: [ + getAbsolutePath('@storybook/addon-a11y'), + getAbsolutePath('storybook-addon-accessibility-checker'), { name: getAbsolutePath('@storybook/addon-docs'), options: { diff --git a/packages/ibm-products-web-components/package.json b/packages/ibm-products-web-components/package.json index 9779cdc1263..0bf8cf3d694 100644 --- a/packages/ibm-products-web-components/package.json +++ b/packages/ibm-products-web-components/package.json @@ -77,9 +77,10 @@ "@rollup/plugin-json": "^6.1.0", "@rollup/plugin-node-resolve": "^16.0.0", "@rollup/plugin-typescript": "^12.1.1", - "@storybook/addon-docs": "^9.0.5", - "@storybook/addon-links": "^9.0.0", - "@storybook/web-components-vite": "^9.0.12", + "@storybook/addon-a11y": "^9.1.8", + "@storybook/addon-docs": "^9.1.8", + "@storybook/addon-links": "^9.1.8", + "@storybook/web-components-vite": "^9.1.8", "@types/jest": "^29.5.13", "@vitest/browser": "^3.2.0", "@vitest/coverage-v8": "^3.2.0", @@ -97,7 +98,8 @@ "rollup": "^4.27.3", "rollup-plugin-copy": "^3.5.0", "sass": "^1.80.6", - "storybook": "^9.0.5", + "storybook": "^9.1.8", + "storybook-addon-accessibility-checker": ">=9.2.0-rc.0", "tslib": "^2.8.1", "typescript": "^5.5.3", "vite": "^7.0.0", diff --git a/packages/ibm-products/.storybook/main.js b/packages/ibm-products/.storybook/main.js index 3e2dec82215..505390680a1 100644 --- a/packages/ibm-products/.storybook/main.js +++ b/packages/ibm-products/.storybook/main.js @@ -23,9 +23,9 @@ export default { staticDirs: ['../public'], addons: [ - // getAbsolutePath('@storybook/addon-controls'), + getAbsolutePath('@storybook/addon-a11y'), + getAbsolutePath('storybook-addon-accessibility-checker'), getAbsolutePath('@storybook/addon-links'), - // getAbsolutePath('@storybook/addon-viewport'), { name: '@storybook/addon-docs', options: { diff --git a/packages/ibm-products/package.json b/packages/ibm-products/package.json index 5ee08c4f6cf..d7459499d63 100644 --- a/packages/ibm-products/package.json +++ b/packages/ibm-products/package.json @@ -76,10 +76,11 @@ "@rollup/plugin-commonjs": "^28.0.3", "@rollup/plugin-node-resolve": "^16.0.1", "@rollup/plugin-typescript": "^12.1.2", - "@storybook/addon-docs": "^9.0.8", - "@storybook/addon-links": "^9.0.8", + "@storybook/addon-a11y": "^9.1.8", + "@storybook/addon-docs": "^9.1.8", + "@storybook/addon-links": "^9.1.8", "@storybook/csf": "^0.1.13", - "@storybook/react-vite": "^9.0.13", + "@storybook/react-vite": "^9.1.8", "@types/react-table": "^7.7.20", "babel-plugin-dev-expression": "^0.2.3", "babel-preset-ibm-cloud-cognitive": "^0.34.0-rc.0", @@ -100,7 +101,8 @@ "rollup": "^4.35.0", "rollup-plugin-strip-banner": "^3.1.0", "sass": "^1.85.1", - "storybook": "^9.0.8", + "storybook": "^9.1.8", + "storybook-addon-accessibility-checker": ">=9.2.0-rc.0", "typescript-config-carbon": "^0.7.0", "vite": "^7.0.0", "yargs": "^18.0.0" diff --git a/yarn.lock b/yarn.lock index c76a8c86d0c..e0f0b1ff235 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1970,9 +1970,10 @@ __metadata: "@rollup/plugin-json": "npm:^6.1.0" "@rollup/plugin-node-resolve": "npm:^16.0.0" "@rollup/plugin-typescript": "npm:^12.1.1" - "@storybook/addon-docs": "npm:^9.0.5" - "@storybook/addon-links": "npm:^9.0.0" - "@storybook/web-components-vite": "npm:^9.0.12" + "@storybook/addon-a11y": "npm:^9.1.8" + "@storybook/addon-docs": "npm:^9.1.8" + "@storybook/addon-links": "npm:^9.1.8" + "@storybook/web-components-vite": "npm:^9.1.8" "@types/jest": "npm:^29.5.13" "@vitest/browser": "npm:^3.2.0" "@vitest/coverage-v8": "npm:^3.2.0" @@ -1991,7 +1992,8 @@ __metadata: rollup: "npm:^4.27.3" rollup-plugin-copy: "npm:^3.5.0" sass: "npm:^1.80.6" - storybook: "npm:^9.0.5" + storybook: "npm:^9.1.8" + storybook-addon-accessibility-checker: "npm:>=9.2.0-rc.0" tslib: "npm:^2.8.1" typescript: "npm:^5.5.3" vite: "npm:^7.0.0" @@ -2034,10 +2036,11 @@ __metadata: "@rollup/plugin-commonjs": "npm:^28.0.3" "@rollup/plugin-node-resolve": "npm:^16.0.1" "@rollup/plugin-typescript": "npm:^12.1.2" - "@storybook/addon-docs": "npm:^9.0.8" - "@storybook/addon-links": "npm:^9.0.8" + "@storybook/addon-a11y": "npm:^9.1.8" + "@storybook/addon-docs": "npm:^9.1.8" + "@storybook/addon-links": "npm:^9.1.8" "@storybook/csf": "npm:^0.1.13" - "@storybook/react-vite": "npm:^9.0.13" + "@storybook/react-vite": "npm:^9.1.8" "@types/react-table": "npm:^7.7.20" babel-plugin-dev-expression: "npm:^0.2.3" babel-preset-ibm-cloud-cognitive: "npm:^0.34.0-rc.0" @@ -2060,7 +2063,8 @@ __metadata: rollup: "npm:^4.35.0" rollup-plugin-strip-banner: "npm:^3.1.0" sass: "npm:^1.85.1" - storybook: "npm:^9.0.8" + storybook: "npm:^9.1.8" + storybook-addon-accessibility-checker: "npm:>=9.2.0-rc.0" typescript-config-carbon: "npm:^0.7.0" vite: "npm:^7.0.0" yargs: "npm:^18.0.0" @@ -6000,35 +6004,47 @@ __metadata: languageName: node linkType: hard -"@storybook/addon-docs@npm:^9.0.5, @storybook/addon-docs@npm:^9.0.8": - version: 9.0.15 - resolution: "@storybook/addon-docs@npm:9.0.15" +"@storybook/addon-a11y@npm:^9.1.8": + version: 9.1.9 + resolution: "@storybook/addon-a11y@npm:9.1.9" + dependencies: + "@storybook/global": "npm:^5.0.0" + axe-core: "npm:^4.2.0" + peerDependencies: + storybook: ^9.1.9 + checksum: 10/f3a76ec154b5f3a9cd5383640ef883c8b2fd0dacd50115b268d4d36c83d4d5f6a40600eb35dc408ccf1c2d4ea6c5de358f53e201740c8bbc415458176556f0c8 + languageName: node + linkType: hard + +"@storybook/addon-docs@npm:^9.1.8": + version: 9.1.9 + resolution: "@storybook/addon-docs@npm:9.1.9" dependencies: "@mdx-js/react": "npm:^3.0.0" - "@storybook/csf-plugin": "npm:9.0.15" - "@storybook/icons": "npm:^1.2.12" - "@storybook/react-dom-shim": "npm:9.0.15" + "@storybook/csf-plugin": "npm:9.1.9" + "@storybook/icons": "npm:^1.4.0" + "@storybook/react-dom-shim": "npm:9.1.9" react: "npm:^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0" react-dom: "npm:^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0" ts-dedent: "npm:^2.0.0" peerDependencies: - storybook: ^9.0.15 - checksum: 10/0b3c75f0410f09d1094db55659560c7ca789f3b4d796c3a137a7fb9ca70961a0cef4368873c4bf245667de5c68f6f6c1c0682da3c75cfb4430e9c8b6eca5c6a5 + storybook: ^9.1.9 + checksum: 10/33aabdba0730d39e00486b798c9111e8ac727723fb6093624efc033ff15dcd4d476990d8fd579f83c4edf64982ebb99235ced77918589f166320d6d295cecd38 languageName: node linkType: hard -"@storybook/addon-links@npm:^9.0.0, @storybook/addon-links@npm:^9.0.8": - version: 9.0.15 - resolution: "@storybook/addon-links@npm:9.0.15" +"@storybook/addon-links@npm:^9.1.8": + version: 9.1.9 + resolution: "@storybook/addon-links@npm:9.1.9" dependencies: "@storybook/global": "npm:^5.0.0" peerDependencies: react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta - storybook: ^9.0.15 + storybook: ^9.1.9 peerDependenciesMeta: react: optional: true - checksum: 10/797fa5ef3e2cdf3301a4e0d0faff2ee27e3eca74df504d92ba38f5a4df501d2e01f3e3e9c013f67ca3d1fb88fae475857ab66dc7fdb751b5389e31fd16fd4f03 + checksum: 10/80a85b9de8f68837f1bc955deb871b67b7bead726de818202b0d478a6455b5ce84be181eb46653c001afb3d83432b2ccce87b8509ee5053686932f0a16c4328e languageName: node linkType: hard @@ -6053,16 +6069,16 @@ __metadata: languageName: node linkType: hard -"@storybook/builder-vite@npm:9.0.15": - version: 9.0.15 - resolution: "@storybook/builder-vite@npm:9.0.15" +"@storybook/builder-vite@npm:9.1.9": + version: 9.1.9 + resolution: "@storybook/builder-vite@npm:9.1.9" dependencies: - "@storybook/csf-plugin": "npm:9.0.15" + "@storybook/csf-plugin": "npm:9.1.9" ts-dedent: "npm:^2.0.0" peerDependencies: - storybook: ^9.0.15 + storybook: ^9.1.9 vite: ^5.0.0 || ^6.0.0 || ^7.0.0 - checksum: 10/2704f61939305d956a1cc193058633466145cd5d1c00a75b3f1af7f8ed60d8c24f2135afc37b36825caeb90e8c5c343eb47f1be4aabb6d18dffe783f73926bb8 + checksum: 10/579a1d3cfe83302b059e445c22f297f490075371558dc2064d89ebca85088580914b56cf51315c360bc561de81c207208ea128f699b36131a944daaec67b10e7 languageName: node linkType: hard @@ -6135,14 +6151,14 @@ __metadata: languageName: node linkType: hard -"@storybook/csf-plugin@npm:9.0.15": - version: 9.0.15 - resolution: "@storybook/csf-plugin@npm:9.0.15" +"@storybook/csf-plugin@npm:9.1.9": + version: 9.1.9 + resolution: "@storybook/csf-plugin@npm:9.1.9" dependencies: unplugin: "npm:^1.3.1" peerDependencies: - storybook: ^9.0.15 - checksum: 10/a8e6ac17c3b51a59c6dda264b64efa4b09f51e095e0b4c148b13d4dd78a454d4b108e0c510e33a02efc96d95338d3f0ae5b308a35265b87cbabadf21b27f8b92 + storybook: ^9.1.9 + checksum: 10/fcc1b7438b72d7904b90676df112db7acf4da1e62485aba8411ba62e9ccd6c1b86e2e6b522d7ab1ae78399b0720a9ab53ea23e5254233325fdbe3a212d24f451 languageName: node linkType: hard @@ -6162,13 +6178,13 @@ __metadata: languageName: node linkType: hard -"@storybook/icons@npm:^1.2.12": - version: 1.3.2 - resolution: "@storybook/icons@npm:1.3.2" +"@storybook/icons@npm:^1.4.0": + version: 1.6.0 + resolution: "@storybook/icons@npm:1.6.0" peerDependencies: react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta - checksum: 10/40dc378e3e42a0f37985df538920b5b032d19c3166155f0000d2f7cc317ff20dc83a28b4e2f2d291d5e2b3e4875401b1896e8a95da3c18f3e6ea417b574092b4 + checksum: 10/f9036ca3b0d2904778eb4e202305f2780b549434380f9760f0bc704fe3ee19d7332f9560a66435ebb2156346cee9a863e40fa5e4b27790bf993b0c1180a3146d languageName: node linkType: hard @@ -6216,25 +6232,25 @@ __metadata: languageName: node linkType: hard -"@storybook/react-dom-shim@npm:9.0.15": - version: 9.0.15 - resolution: "@storybook/react-dom-shim@npm:9.0.15" +"@storybook/react-dom-shim@npm:9.1.9": + version: 9.1.9 + resolution: "@storybook/react-dom-shim@npm:9.1.9" peerDependencies: react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta - storybook: ^9.0.15 - checksum: 10/f83d768ac21b9eb91e8e92a4c67a7757de49f3cc27d31e89ac165e47c6876dc309b12a2be3a545665c17622435a10688e7cf709b163aeb251eea8902bde3e428 + storybook: ^9.1.9 + checksum: 10/5ee03b00e9b2760eec54585f7a4f436735ce3a1714a0fd387908a2c32ad5e812560db3c2094c8a06aa316daee1f4403aa69eaa9688ecfb9f378caa95ce16f154 languageName: node linkType: hard -"@storybook/react-vite@npm:^9.0.13": - version: 9.0.15 - resolution: "@storybook/react-vite@npm:9.0.15" +"@storybook/react-vite@npm:^9.1.8": + version: 9.1.9 + resolution: "@storybook/react-vite@npm:9.1.9" dependencies: "@joshwooding/vite-plugin-react-docgen-typescript": "npm:0.6.1" "@rollup/pluginutils": "npm:^5.0.2" - "@storybook/builder-vite": "npm:9.0.15" - "@storybook/react": "npm:9.0.15" + "@storybook/builder-vite": "npm:9.1.9" + "@storybook/react": "npm:9.1.9" find-up: "npm:^7.0.0" magic-string: "npm:^0.30.0" react-docgen: "npm:^8.0.0" @@ -6243,27 +6259,27 @@ __metadata: peerDependencies: react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta - storybook: ^9.0.15 + storybook: ^9.1.9 vite: ^5.0.0 || ^6.0.0 || ^7.0.0 - checksum: 10/366070d57b817c09f39ea2cb3b4398eb726995aaaf842a05292a5bdf3486623ef47058c3ad9a113212512d409b983bf3b60a5805489be6862d3d82c812e35137 + checksum: 10/ae5f5291fb03d64fd2374b31770aa15daa64ccba459ba67fb346425d4549a3e48b8407cc0c443ac847eaa57a48b80f49fe590e81c89b9e1242848fb515817e38 languageName: node linkType: hard -"@storybook/react@npm:9.0.15": - version: 9.0.15 - resolution: "@storybook/react@npm:9.0.15" +"@storybook/react@npm:9.1.9": + version: 9.1.9 + resolution: "@storybook/react@npm:9.1.9" dependencies: "@storybook/global": "npm:^5.0.0" - "@storybook/react-dom-shim": "npm:9.0.15" + "@storybook/react-dom-shim": "npm:9.1.9" peerDependencies: react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0-beta - storybook: ^9.0.15 + storybook: ^9.1.9 typescript: ">= 4.9.x" peerDependenciesMeta: typescript: optional: true - checksum: 10/3a4c2a4a52d12c78787f5c67812d5d0f91accb9cbe88d935dcd5997a47c5221ad2dd5ec958dd7fdf8db71628e3a4cb65b13dbfa83b4f195c85c1cf9f8341831f + checksum: 10/c8b1d70df8507cae01f9fc4a1afaba0bac761bc693fad8543c1507cfb3058854bbae47a8578ed471b925dccaefe13999f559787bc062ca9917a6eaa0b29fa97c languageName: node linkType: hard @@ -6314,29 +6330,29 @@ __metadata: languageName: node linkType: hard -"@storybook/web-components-vite@npm:^9.0.12": - version: 9.0.15 - resolution: "@storybook/web-components-vite@npm:9.0.15" +"@storybook/web-components-vite@npm:^9.1.8": + version: 9.1.9 + resolution: "@storybook/web-components-vite@npm:9.1.9" dependencies: - "@storybook/builder-vite": "npm:9.0.15" - "@storybook/web-components": "npm:9.0.15" + "@storybook/builder-vite": "npm:9.1.9" + "@storybook/web-components": "npm:9.1.9" peerDependencies: - storybook: ^9.0.15 - checksum: 10/3060861d9a24066198041b6543dba075ee459adbfa7c0b9f6ba6788f2941a03a96dedec6e0c66eaf6667315406721800109f5e38387ac6e9190043e48f7491bc + storybook: ^9.1.9 + checksum: 10/e77e95cf9ff40e564a8e7cf6b1143df265e93680878fc5a15c8712a37fca472c95a1ff7b1171aa2cc2e7e45410418f137aa8afb6c564ddfcc1ce6a99740385f7 languageName: node linkType: hard -"@storybook/web-components@npm:9.0.15": - version: 9.0.15 - resolution: "@storybook/web-components@npm:9.0.15" +"@storybook/web-components@npm:9.1.9": + version: 9.1.9 + resolution: "@storybook/web-components@npm:9.1.9" dependencies: "@storybook/global": "npm:^5.0.0" tiny-invariant: "npm:^1.3.1" ts-dedent: "npm:^2.0.0" peerDependencies: lit: ^2.0.0 || ^3.0.0 - storybook: ^9.0.15 - checksum: 10/439cde3101178bbc9b6972d8f8922186eff46c7ee6664ecc1be23c68dd31085f271878f29364871b4dff8cf5a9580d0817c4bff16c3ff676339a5dbecb4c6375 + storybook: ^9.1.9 + checksum: 10/0a7114da6809546b8c9cd1209cdcea51ce7c2de1c02af2cdaf0c5784c58768baccf0e64b488b70495fdc7aa3007697f455d99e8a1da9358dea448d3a39b49eae languageName: node linkType: hard @@ -7946,6 +7962,13 @@ __metadata: languageName: node linkType: hard +"accessibility-checker-engine@npm:^4.0.8": + version: 4.0.9 + resolution: "accessibility-checker-engine@npm:4.0.9" + checksum: 10/d94dfbe6574b43da4963e4a75b9e7445c2c0216c97ed09cbaf8e3dca7bb844c4e3b2d5eabb1359e8274d56067138f99b2780b0174ae98a14913cebf767f58c2d + languageName: node + linkType: hard + "accessibility-checker@npm:^4.0.7": version: 4.0.7 resolution: "accessibility-checker@npm:4.0.7" @@ -8521,7 +8544,7 @@ __metadata: languageName: node linkType: hard -"axe-core@npm:^4.10.0, axe-core@npm:^4.10.3, axe-core@npm:^4.3.3": +"axe-core@npm:^4.10.0, axe-core@npm:^4.10.3, axe-core@npm:^4.2.0, axe-core@npm:^4.3.3": version: 4.10.3 resolution: "axe-core@npm:4.10.3" checksum: 10/9ff51ad0fd0fdec5c0247ea74e8ace5990b54c7f01f8fa3e5cd8ba98b0db24d8ebd7bab4a9bd4d75c28c4edcd1eac455b44c8c6c258c6a98f3d2f88bc60af4cc @@ -20850,14 +20873,28 @@ __metadata: languageName: node linkType: hard -"storybook@npm:^9.0.5, storybook@npm:^9.0.8": - version: 9.0.15 - resolution: "storybook@npm:9.0.15" +"storybook-addon-accessibility-checker@npm:>=9.2.0-rc.0": + version: 9.2.0-rc.0 + resolution: "storybook-addon-accessibility-checker@npm:9.2.0-rc.0" + dependencies: + "@storybook/global": "npm:^5.0.0" + accessibility-checker-engine: "npm:^4.0.8" + axe-core: "npm:^4.2.0" + peerDependencies: + storybook: "workspace:^" + checksum: 10/022d02d7ef6ca0303c5135baa52e75c5b05ef60a36fe2e7c22c7caf4dcb1eb46834020519a9fb125564cccdefdca4483440df05b9c4608dbf7f15604fe7841bc + languageName: node + linkType: hard + +"storybook@npm:^9.1.8": + version: 9.1.9 + resolution: "storybook@npm:9.1.9" dependencies: "@storybook/global": "npm:^5.0.0" "@testing-library/jest-dom": "npm:^6.6.3" "@testing-library/user-event": "npm:^14.6.1" "@vitest/expect": "npm:3.2.4" + "@vitest/mocker": "npm:3.2.4" "@vitest/spy": "npm:3.2.4" better-opn: "npm:^3.0.2" esbuild: "npm:^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0 || ^0.25.0" @@ -20872,7 +20909,7 @@ __metadata: optional: true bin: storybook: ./bin/index.cjs - checksum: 10/4ad21bd6cb9ff154ceb0d98360755727002c2ac9fb8ad8382e4abcf7be555d60fb43b5a60ee2ad820fedc3317c5505a704bb4f5ede159d0bda0dbd795bd652d2 + checksum: 10/6a53c5ddacd2e891da78c0d98065e2350788b05d879dc0a144562d894609e07409d5ade270699a04f922ec4e0e53ee9293d100f7f10fdbe150421b56c07569e2 languageName: node linkType: hard