⬆️ Bump flow-bin from 0.133.0 to 0.134.0 (#53)

Author: dependabot-preview[bot]

.flowconfig

@@ -2,4 +2,4 @@
 .*/node_modules/react-native/Libraries/react-native/react-native-implementation.js
 
 [version]
-^0.133.0
+^0.134.0

package.json

@@ -58,7 +58,7 @@
     "codecov": "^3.1.0",
     "eslint": "^7.5.0",
     "eslint-plugin-flowtype": "^5.2.0",
-    "flow-bin": "^0.133.0",
+    "flow-bin": "^0.134.0",
     "jest": "^24.9.0",
     "react": "16.6.3",
     "react-native": "^0.58.4",

src/ErrorBoundary/FallbackComponent/index.js

@@ -1,5 +1,5 @@
 // @flow
-import React from 'react'
+import React, { type Node } from 'react'
 import {
   SafeAreaView,
   Text,
@@ -9,9 +9,9 @@ import {
 
 import styles from './styles'
 
-type Props = { error: Error, resetError: Function }
+export type Props = { error: Error, resetError: Function }
 
-const FallbackComponent = (props: Props) => (
+const FallbackComponent = (props: Props): Node => (
   <SafeAreaView style={styles.container}>
     <View style={styles.content}>
       <Text style={styles.title}>{'Oops!'}</Text>

src/ErrorBoundary/FallbackComponent/styles.js

@@ -1,7 +1,7 @@
 // @flow
 import { StyleSheet } from 'react-native'
 
-export default StyleSheet.create({
+const styles: any = StyleSheet.create({
   container: {
     backgroundColor: '#fafafa',
     flex: 1,
@@ -33,3 +33,5 @@ export default StyleSheet.create({
     textAlign: 'center'
   }
 })
+
+export default styles

src/ErrorBoundary/index.js

@@ -1,25 +1,25 @@
 // @flow
 import React, { type Node, type ComponentType } from 'react'
 
-import FallbackComponent from './FallbackComponent'
+import FallbackComponent, { type Props as FallbackComponentProps } from './FallbackComponent'
 
 type Props = {
   children: Node,
-  FallbackComponent: ComponentType<any>,
+  FallbackComponent: ComponentType<FallbackComponentProps>,
   onError?: Function
 }
 
-type State = { error: Error | null, hasError: boolean }
+type State = { error: Error | null }
 
 class ErrorBoundary extends React.Component<Props, State> {
-  state = { error: null, hasError: false }
+  state: State = { error: null }
 
-  static defaultProps = {
+  static defaultProps: { FallbackComponent: ComponentType<FallbackComponentProps> } = {
     FallbackComponent: FallbackComponent
   }
 
-  static getDerivedStateFromError (error: Error) {
-    return { error, hasError: true }
+  static getDerivedStateFromError (error: Error): State {
+    return { error }
   }
 
   componentDidCatch (error: Error, info: { componentStack: string }) {
@@ -29,13 +29,13 @@ class ErrorBoundary extends React.Component<Props, State> {
   }
 
   resetError: Function = () => {
-    this.setState({ error: null, hasError: false })
+    this.setState({ error: null })
   }
 
-  render () {
+  render (): Node {
     const { FallbackComponent } = this.props
 
-    return this.state.hasError
+    return this.state.error
       ? <FallbackComponent
         error={this.state.error}
         resetError={this.resetError}

src/__tests__/__snapshots__/errorBoundary.spec.js.snap

@@ -48,8 +48,8 @@ exports[`ErrorBoundary should catch errors set the state and render the default
     >
       Invariant Violation: Objects are not valid as a React child (found: Error: This is a test error!). If you meant to render a collection of children, use an array instead.
     in View (created by View)
-    in View (at errorBoundary.spec.js:41)
-    in ErrorBoundary (at errorBoundary.spec.js:40)
+    in View (at errorBoundary.spec.js:40)
+    in ErrorBoundary (at errorBoundary.spec.js:39)
     </Text>
     <View
       accessible={true}

src/__tests__/errorBoundary.spec.js

@@ -31,7 +31,6 @@ describe('ErrorBoundary', () => {
       </ErrorBoundary>
     )
     expect(wrapper.getInstance().state.error).toBe(null)
-    expect(wrapper.getInstance().state.hasError).toBe(false)
     expect(wrapper).toMatchSnapshot()
   })
 
@@ -41,7 +40,8 @@ describe('ErrorBoundary', () => {
         <View>{errorMock}</View>
       </ErrorBoundary>
     )
-    expect(wrapper.getInstance().state.hasError).toBe(true)
+    expect(wrapper.getInstance().state.error).toBeInstanceOf(Error)
+    expect(wrapper.getInstance().state.error).not.toBeNull()
     expect(wrapper).toMatchSnapshot()
   })
 
@@ -53,8 +53,8 @@ describe('ErrorBoundary', () => {
         <View>{errorMock}</View>
       </ErrorBoundary>
     )
+    expect(wrapper.getInstance().state.error).toBeInstanceOf(Error)
     expect(wrapper.getInstance().state.error).not.toBeNull()
-    expect(wrapper.getInstance().state.hasError).toBe(true)
     expect(onError).toHaveBeenCalledWith(expect.any(Error), expect.any(String))
     expect(wrapper).toMatchSnapshot()
   })
@@ -65,9 +65,8 @@ describe('ErrorBoundary', () => {
         <Text>No errors!</Text>
       </ErrorBoundary>
     )
-    wrapper.getInstance().setState({ error: errorMock, hasError: true })
+    wrapper.getInstance().setState({ error: errorMock })
     wrapper.getInstance().resetError()
     expect(wrapper.getInstance().state.error).toBeNull()
-    expect(wrapper.getInstance().state.hasError).toBe(false)
   })
 })

yarn.lock

@@ -2841,10 +2841,10 @@ flatted@^2.0.0:
   resolved "https://registry.yarnpkg.com/flatted/-/flatted-2.0.2.tgz#4575b21e2bcee7434aa9be662f4b7b5f9c2b5138"
   integrity sha512-r5wGx7YeOwNWNlCA0wQ86zKyDLMQr+/RB8xy74M4hTphfmjlijTSSXGuH8rnvKZnfT9i+75zmd8jcKdMR4O6jA==
 
-flow-bin@^0.133.0:
-  version "0.133.0"
-  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.133.0.tgz#2ee44e3f5d0c0256cfe8e99d9a85e9801c281c50"
-  integrity sha512-01T5g8GdhtJEn+lhAwuv5zkrMStrmkuHrY3Nn9/aS9y6waNmNgimMKlzRpFH66S0F6Ez9EqU9psz5QaRveSJIA==
+flow-bin@^0.134.0:
+  version "0.134.0"
+  resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.134.0.tgz#e98e5724f6ed5a1265cf904bbb5e4c096ea3a026"
+  integrity sha512-j5aCugO3jmwDsUKc+7KReArgnL6aVjHLo6DlozKhxKYN+TaP8BY+mintPSISjSQtKZFJyvoNAc1oXA79X5WjIA==
 
 for-in@^1.0.1, for-in@^1.0.2:
   version "1.0.2"