Skip to content

Commit 7cfb90e

Browse files
committed
Migrate from legacy Helm to OCI
Signed-off-by: Erik Godding Boye <[email protected]>
1 parent eb7d14f commit 7cfb90e

File tree

2 files changed

+13
-31
lines changed

2 files changed

+13
-31
lines changed

RELEASE.md

Lines changed: 10 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,12 @@
22

33
## Schedule
44

5-
The release schedule for this project is ad-hoc. Given the pre-1.0 status of the project we do not have a fixed release cadence. However if a vulnerability is discovered we will respond in accordance with our [security policy](https://github.com/cert-manager/community/blob/main/SECURITY.md) and this response may include a release.
5+
The release schedule for this project is ad-hoc. Given the pre-1.0 status of the project we do not have a fixed release cadence.
6+
However, if a vulnerability is discovered we will respond in accordance with our [security policy](https://github.com/cert-manager/community/blob/main/SECURITY.md) and this response may include a release.
67

78
## Process
89

9-
There is a semi-automated release process for this project. When you create a Git tag with a tagname that has a `v` prefix and push it to GitHub it will trigger the [release workflow].
10-
11-
### Preparing for a Release
12-
13-
**BEFORE** doing a release, check if the other images in the csi-driver Helm
14-
chart need to be updated.
15-
16-
These are:
17-
18-
- registry.k8s.io/sig-storage/livenessprobe (`.Values.livenessProbeImage.tag`)
19-
- registry.k8s.io/sig-storage/csi-node-driver-registrar (`.Values.nodeDriverRegistrarImage.tag`)
20-
21-
The latest image can be checked using `crane`:
22-
23-
```console
24-
$ crane ls registry.k8s.io/sig-storage/livenessprobe | sort -V
25-
26-
$ crane ls registry.k8s.io/sig-storage/csi-node-driver-registrar | sort -V
27-
```
28-
29-
### Doing a Release
10+
There is a semi-automated release process for this project. When you create a Git tag with a tag name that has a `v` prefix and push it to GitHub it will trigger the [release workflow].
3011

3112
The release process for this repo is documented below:
3213

@@ -38,21 +19,22 @@ The release process for this repo is documented below:
3819
```
3920
2. A GitHub action will see the new tag and do the following:
4021
- Build and publish any container images
41-
- Build and publish the Helm chart
22+
- Build and publish the OCI Helm chart
4223
- Create a draft GitHub release
43-
3. Wait for the PR to be merged and wait for OCI Helm chart to propagate and become available from https://charts.jetstack.io (this might take a few hours).
44-
4. Visit the [releases page], edit the draft release, click "Generate release notes", then edit the notes to add the following to the top
24+
3. Visit the [releases page], edit the draft release, click "Generate release notes", then edit the notes to add the following to the top
4525
```
4626
cert-manager-csi-driver enables issuing secretless X.509 certificates for pods using cert-manager!
4727
```
48-
5. Publish the release.
28+
4. Publish the release.
4929
5030
## Artifacts
5131
5232
This repo will produce the following artifacts each release. For documentation on how those artifacts are produced see the "Process" section.
5333
54-
- *Container Images* - Container images for the are published to `quay.io/jetstack`.
55-
- *Helm chart* - An official Helm chart is maintained within this repo and published to `quay.io/jetstack` and `charts.jetstack.io` on each release.
34+
- *Container Images* - Container images for the project are published to `quay.io/jetstack`.
35+
- *Helm chart* - An official Helm chart is maintained within this repo and published to `quay.io/jetstack` on each release.
36+
- The chart is also published to the legacy HTTP Helm repository at `https://charts.jetstack.io` (maintained by Venafi).
37+
Publishing to the legacy repo depends on a PR to be merged in a closed Venafi repo, and might be delayed.
5638
5739
[release workflow]: https://github.com/cert-manager/csi-driver/actions/workflows/release.yaml
5840
[releases page]: https://github.com/cert-manager/csi-driver/releases

make/test-e2e.mk

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
.PHONY: e2e-setup-cert-manager
1616
e2e-setup-cert-manager: | kind-cluster $(NEEDS_HELM) $(NEEDS_KUBECTL)
1717
$(HELM) upgrade \
18+
cert-manager oci://quay.io/jetstack/charts/cert-manager \
1819
--install \
1920
--create-namespace \
2021
--wait \
21-
--version $(quay.io/jetstack/cert-manager-controller.TAG) \
22+
--version $(cert_manager_version) \
2223
--namespace cert-manager \
23-
--repo https://charts.jetstack.io \
2424
--set installCRDs=true \
2525
--set image.repository=$(quay.io/jetstack/cert-manager-controller.REPO) \
2626
--set image.tag=$(quay.io/jetstack/cert-manager-controller.TAG) \
@@ -34,7 +34,7 @@ e2e-setup-cert-manager: | kind-cluster $(NEEDS_HELM) $(NEEDS_KUBECTL)
3434
--set startupapicheck.image.repository=$(quay.io/jetstack/cert-manager-startupapicheck.REPO) \
3535
--set startupapicheck.image.tag=$(quay.io/jetstack/cert-manager-startupapicheck.TAG) \
3636
--set startupapicheck.image.pullPolicy=Never \
37-
cert-manager cert-manager >/dev/null
37+
>/dev/null
3838

3939
# The "install" target can be run on its own with any currently active cluster,
4040
# we can't use any other cluster then a target containing "test-e2e" is run.

0 commit comments

Comments
 (0)