Skip to content

Support array for multiple roots? #148

@gilbert

Description

@gilbert

Here's a case when multiple roots throws an error:

var html = require('nanohtml')

var nums = [10,20,30]

var el = html`
  <main>
    <h1>Hello planet</h1>
  </main>
  ${nums.map(n =>
    html`<div>${n}</div>`
  )}
`
document.body.appendChild(el)

Updating nanohtml's createFragment to look something like this solves the problem:

function createFragment (nodes) {
  var fragment = document.createDocumentFragment()
  for (var i = 0; i < nodes.length; i++) {
    if (typeof nodes[i] === 'string') nodes[i] = document.createTextNode(nodes[i])

    if (Array.isArray(nodes[i])) {
      for (var n=0; n < nodes[i].length; n++) {
        fragment.appendChild(nodes[i][n])
      }
    }
    else {
      fragment.appendChild(nodes[i])
    }
  }
  return fragment
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions