PHP Lint fixes.

Author: alan-cole

web/themes/contrib/civictheme/includes/search.inc

@@ -40,6 +40,8 @@ function civictheme_preprocess_block__civictheme_search(array &$variables): void
 
 /**
  * Implements hook_preprocess_html().
+ *
+ * @SuppressWarnings(PHPMD.StaticAccess)
  */
 function _civictheme_preprocess_html__search_head_title(array &$variables): void {
   // Load search fields from theme settings.

web/themes/contrib/civictheme/includes/views.inc

@@ -162,19 +162,9 @@ function civictheme_preprocess_views_exposed_form(array &$variables): void {
   }
 
   if ($field_count == 1) {
-    // Use inline filter on search and auto pages if a single text field exsits.
-    if ($view instanceof \Drupal\views\ViewExecutable && in_array($view->id(), ['civictheme_search', 'civictheme_automated_list'])) {
-      $keyword_field = reset($fields);
-      if ($keyword_field['#type'] === 'textfield') {
-        $variables['inline_filter'] = TRUE;
-        $keyword_field['#title_size'] = 'extra-large';
-        $variables['filter_items'] = $keyword_field;
-        $submit_field = $variables['form']['actions']['submit'] ?? NULL;
-        if (!empty($submit_field)) {
-          $variables['submit_text'] = $submit_field['#value'] ?? '';
-        }
-        return;
-      }
+    // Use inline filter on search and auto pages if a single text field exists.
+    if (_civictheme_preprocess_views__exposed_form__inline_filter($variables, $view, $fields)) {
+      return;
     }
 
     // Use single filter.
@@ -185,6 +175,44 @@ function civictheme_preprocess_views_exposed_form(array &$variables): void {
   }
 }
 
+/**
+ * Preprocess views exposed form to convert it to the Inline filter.
+ *
+ * @param array $variables
+ *   Variables array.
+ * @param \Drupal\views\ViewExecutable|null $view
+ *   The view object.
+ * @param array $fields
+ *   Form fields.
+ *
+ * @return bool
+ *   TRUE if inline filter was processed, FALSE otherwise.
+ */
+function _civictheme_preprocess_views__exposed_form__inline_filter(array &$variables, $view, array $fields): bool {
+  if (!($view instanceof \Drupal\views\ViewExecutable)) {
+    return FALSE;
+  }
+
+  if (!in_array($view->id(), ['civictheme_search', 'civictheme_automated_list'])) {
+    return FALSE;
+  }
+
+  $keyword_field = reset($fields);
+  if ($keyword_field['#type'] !== 'textfield') {
+    return FALSE;
+  }
+
+  $variables['inline_filter'] = TRUE;
+  $keyword_field['#title_size'] = 'extra-large';
+  $variables['filter_items'] = $keyword_field;
+  $submit_field = $variables['form']['actions']['submit'] ?? NULL;
+  if (!empty($submit_field)) {
+    $variables['submit_text'] = $submit_field['#value'] ?? '';
+  }
+
+  return TRUE;
+}
+
 /**
  * Preprocess views exposed form to convert it to the Single filter.
  */
@@ -282,6 +310,8 @@ function _civictheme_preprocess_views_view__search_page(array &$variables): void
 
 /**
  * Pre-process results count for views.
+ *
+ * @SuppressWarnings(PHPMD.StaticAccess)
  */
 function _civictheme_preprocess_views_view__results_count(array &$variables): void {
   if (empty($variables['results_count'])) {