fix(localizations,shared): Localize the invalid and expired ticket errors - #9601
Merged
dmoerner merged 1 commit intoAug 28, 2026
Conversation
…ink errors The `ticket_invalid_code` and `ticket_expired_code` API errors had no `unstable__errors` key, so `translateError` fell through to the backend `longMessage` and showed end users "This ticket is invalid. Make sure you're using a valid ticket generated by Clerk." Both "ticket" and "Clerk" are implementation details to someone who just clicked their IdP tile or an invitation link. Add both keys to `UnstableErrors` and give them end-user copy in en-US, then propagate the keys to the remaining locales via `pnpm generate`. Use copy that is sufficiently general to cover both SAML and invitation paths: ``` ticket_expired_code: 'This link has expired. Please start again or request a new link.', ticket_invalid_code: 'This link is no longer valid or has already been used. Please start again or request a new link.', ``` Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 9c01003 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Contributor
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (51)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 6 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour. 📝 WalkthroughWalkthroughAdds Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change provides end-user messages for invalid and expired links across supported locales. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 45 files. (6 skipped: 1 unsupported, 5 too large.) Comment |
dmoerner
deleted the
daniel/core-3727-localize-the-error-message-after-a-protect-block
branch
August 28, 2026 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ticket_invalid_codeandticket_expired_codeAPI errors had nounstable__errorskey, sotranslateErrorfell through to the backendlongMessageand showed end users "This ticket is invalid. Make sure you're using a valid ticket generated by Clerk." Both "ticket" and "Clerk" are implementation details to someone who just clicked their IdP tile or an invitation link.Add both keys to
UnstableErrorsand give them end-user copy in en-US, then propagate the keys to the remaining locales viapnpm generate.Use copy that is sufficiently general to cover both SAML and invitation paths:
Fixes CORE-3727.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change