Skip to content

CI - Make Internal Tests less brittle #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 7, 2025
Merged

CI - Make Internal Tests less brittle #3536

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27ac717
[bfops/internal-tests-tweak]: CI - Make Internal Tests less brittle
bfops Oct 30, 2025
1b84b75
[bfops/internal-tests-tweak]: try this
bfops Oct 30, 2025
67e9544
[bfops/internal-tests-tweak]: more
bfops Oct 30, 2025
488b384
[bfops/internal-tests-tweak]: try this
bfops Oct 30, 2025
f41f7a1
[bfops/internal-tests-tweak]: fix
bfops Oct 30, 2025
5518dc3
Merge branch 'master' into bfops/internal-tests-tweak
bfops Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/internal-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ jobs:
if: ${{ github.event_name != 'pull_request' || !github.event.pull_request.head.repo.fork }}
runs-on: ubuntu-latest
steps:
- name: Print current ref and sha
run: |
echo "github.ref=${{ github.ref }}"
echo "github.sha=${{ github.sha }}"

- name: Trigger and wait for Internal Tests
uses: actions/github-script@v7
with:
Expand All @@ -35,9 +30,15 @@ jobs:
const targetRepo = 'SpacetimeDBPrivate';
const workflowId = 'internal-tests.yml';
const targetRef = 'master';
const publicRef = context.sha;
// Use the ref for pull requests because the head sha is brittle (github does some extra dance where it merges in master).
const publicRef = (context.eventName === 'pull_request') ? context.payload.pull_request.head.ref : context.sha;
const preDispatch = new Date().toISOString();

console.log("context.eventName =", context.eventName);
console.log("context.ref =", context.ref);
console.log("context.sha =", context.sha);
console.log("Dispatch workflow with publicRef =", publicRef);

// Dispatch the workflow in the target repository
await github.rest.actions.createWorkflowDispatch({
owner: targetOwner,
Expand Down
Loading