Reflectively look up inherited methods when not found in target class

JarrodCTaylor · JarrodCTaylor · commit 9ac37588a58e · 2026-02-11T12:55:38.000-06:00
diff --git a/src/clojure/java/doc/impl.clj b/src/clojure/java/doc/impl.clj
@@ -175,6 +175,26 @@
 (defn- filter-methods [all-methods method-name param-tags]
   (filterv #(method-matches? (:signature %) method-name param-tags) all-methods))
 
+(defn- reflection-type-name [^Class c]
+  (if (.isArray c)
+    (str (reflection-type-name (.getComponentType c)) "[]")
+    (.getSimpleName c)))
+
+(defn- reflection-params-match? [^java.lang.reflect.Method method param-tags]
+  (let [param-type-names (mapv reflection-type-name (.getParameterTypes method))]
+    (params-match? param-type-names param-tags)))
+
+(defn- find-declaring-class [^String class-name method-name param-tags]
+  (let [klass (Class/forName class-name)
+        name-matches?      (fn [^java.lang.reflect.Method m] (= method-name (.getName m)))
+        inherited?         (fn [^java.lang.reflect.Method m] (not= class-name (.getName (.getDeclaringClass m))))
+        params-compatible? (fn [^java.lang.reflect.Method m] (or (nil? param-tags) (reflection-params-match? m param-tags)))
+        matching (->> (.getMethods klass)
+                      (filter (fn [^java.lang.reflect.Method m]
+                                (and (name-matches? m) (inherited? m) (params-compatible? m)))))]
+    (when-let [^java.lang.reflect.Method method (first matching)]
+      (.getName (.getDeclaringClass method)))))
+
 (defn- compress-array-syntax
   "java to clojure param-tag syntax: String[][] -> String/2"
   [java-type]
@@ -249,9 +269,14 @@
                 :class-description-md (when class-html (html-to-md class-html))
                 :methods all-methods}]
     (if method-part
-      (let [filtered (filter-methods all-methods method-part param-tags)]
+      (let [filtered        (filter-methods all-methods method-part param-tags)
+            declaring-class (when (empty? filtered)
+                              (find-declaring-class class-name method-part param-tags))]
         (assoc result :selected-method
-               (mapv #(get-method-detail doc %) filtered)))
+               (cond
+                 (seq filtered) (mapv #(get-method-detail doc %) filtered)
+                 declaring-class (:selected-method (parse-javadoc (str declaring-class "/." method-part) param-tags))
+                 :else [])))
       result)))
 
   (defn print-javadoc [{:keys [classname class-description-md selected-method]}]
diff --git a/test/clojure/java/doc/impl_test.clj b/test/clojure/java/doc/impl_test.clj
@@ -413,6 +413,37 @@
       (is (nil? (#'sut/find-method-section doc "valueOf" ["String"])))
       (is (nil? (#'sut/find-method-section doc "nonExistent" ["int"])))))
 
+(deftest reflection-type-name-test
+
+  (testing "primitive types"
+    (is (= "int" (#'sut/reflection-type-name Integer/TYPE)))
+    (is (= "boolean" (#'sut/reflection-type-name Boolean/TYPE)))
+    (is (= "char" (#'sut/reflection-type-name Character/TYPE)))
+    (is (= "long" (#'sut/reflection-type-name Long/TYPE))))
+
+  (testing "simple class"
+    (is (= "String" (#'sut/reflection-type-name String)))
+    (is (= "Object" (#'sut/reflection-type-name Object))))
+
+  (testing "single dimension array"
+    (is (= "int[]" (#'sut/reflection-type-name (Class/forName "[I"))))
+    (is (= "String[]" (#'sut/reflection-type-name (Class/forName "[Ljava.lang.String;")))))
+
+  (testing "multi dimensional array"
+    (is (= "int[][]" (#'sut/reflection-type-name (Class/forName "[[I"))))
+    (is (= "String[][]" (#'sut/reflection-type-name (Class/forName "[[Ljava.lang.String;"))))))
+
+(deftest find-declaring-class-test
+
+  (testing "inherited method found"
+    (is (= "java.util.zip.ZipEntry" (#'sut/find-declaring-class "java.util.jar.JarEntry" "getName" nil))))
+
+  (testing "directly declared method returns nil"
+    (is (nil? (#'sut/find-declaring-class "java.lang.String" "length" nil))))
+
+  (testing "nonexistent method returns nil"
+    (is (nil? (#'sut/find-declaring-class "java.lang.String" "totallyFakeMethod" nil)))))
+
   (testing "distinguishes between overloads with different param counts"
     (let [html "<html><body>
                 <section id='run(java.util.Map)'>
