DRAFT ACCT-10424 fixing account_token policies, adding account_token tests #5722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AUTH-7350 Fix zero-trust-access policies and groups
…ermission-groups-order api token permission groups order does not matter
…ests fixing api token tests
stainless-app
bot
force-pushed
the
next
branch
2 times, most recently
from
7eafcf9 to
4aff724
Compare
stainless-app
bot
force-pushed
the
next
branch
2 times, most recently
from
46d310b to
21c7400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
While adding account_token tests that mirror the api_token tests, I found a bug that seems to be due to the policies for account tokens being a set instead of a list.
This appears to be the cause of ACCT-10424. The permission groups should be a set but the policies I believe should still be a list.
Additional context & links
#5635