Commit 3e650f8
committed
Remove duplicate mapping key
The error codes `60003` and `290013` appear twice. While many YAML
parsers can cope with duplicate mapping keys, many parser will error
out.
External tools, like for example
[go-cfclient's gen_error.go](https://github.com/cloudfoundry/go-cfclient/blob/main/tools/gen_error.go),
cannot update to more recent major versions of their YAML parser
library:
```shell
yaml: unmarshal errors:
line 221: mapping key "60003" already defined at line 216
line 1036: mapping key "290013" already defined at line 1026
panic: yaml: unmarshal errors:
line 221: mapping key "60003" already defined at line 216
line 1036: mapping key "290013" already defined at line 1026
```
Cloud Controller uses `psych` to parse the errors/*.yml files. Psych
uses the latest occurence of a key. Therefore, the most recent duplicate
key can be picked to stay in the errors files.
```
irb(main):001> require 'psych'
=> true
irb(main):002> filepath = "errors/v2.yml"
=> "errors/v2.yml"
irb(main):003* content = File.open(filepath) do |f|
irb(main):004* Psych.safe_load(f, strict_integer: true)
irb(main):005> end; nil
=> nil
irb(main):006> content[60003]
=> {"name"=>"ServiceInstanceInvalid", "http_code"=>400, "message"=>"The service instance is invalid: %s"}
irb(main):007> content[290013]
=> {"name"=>"SpaceRolesDeletionTimeout", "http_code"=>524, "message"=>"Deletion of roles for space %s timed out before all roles could be deleted"}
```1 parent 99e0b1e commit 3e650f8
1 file changed
+2
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | 216 | | |
222 | 217 | | |
223 | 218 | | |
| |||
1024 | 1019 | | |
1025 | 1020 | | |
1026 | 1021 | | |
1027 | | - | |
| 1022 | + | |
1028 | 1023 | | |
1029 | | - | |
| 1024 | + | |
1030 | 1025 | | |
1031 | 1026 | | |
1032 | 1027 | | |
1033 | 1028 | | |
1034 | 1029 | | |
1035 | 1030 | | |
1036 | | - | |
1037 | | - | |
1038 | | - | |
1039 | | - | |
1040 | | - | |
1041 | 1031 | | |
1042 | 1032 | | |
1043 | 1033 | | |
| |||
0 commit comments