Skip to content

Conversation

@m-pizarro
Copy link
Contributor

…es errors

Issue tracker links

Add links to any relevant tasks/stories/bugs/pagerduty/etc

Example - dummy TODO project

TODO-123

Changes/solution

How does this change address the problem?

Testing

Describe how the testing was done, plus evidence, if not covered by automated tests

Notes and considerations

Add any additional notes and/or considerations

Dependencies

_Add dependencies on any other PRs, if applicable

cacheNodeType: String @search(by: [hash, regexp])
authTokenStatus: String @search(by: [hash, regexp])
logDeliveryConfigurations: [awsElastiCachePendingLogDeliveryConfiguration]
logDeliveryConfigurations: [awsElastiCachePendLogDeliveryConfig]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm do we need to change pending => pend, I wonder if there might be a better way here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what will the query look like on the SQL side with this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I leave the awsElastiCachePendingLogDeliveryConfiguration and rename the logDeliveryConfigurations property to logDeliveryConfigs, let me know if this works for you.

@m-pizarro
Copy link
Contributor Author

m-pizarro commented Nov 15, 2023

@tyler-dunkel This is deprecated, these changes were made to use Hasura. I think we can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants