Skip to content

Stop using deprecated urllib.request.URLopener #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stop using deprecated urllib.request.URLopener #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions wagon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@
try:
import urllib.error
from urllib.request import urlopen
from urllib.request import URLopener
from urllib.request import urlretrieve
except ImportError:
import urllib
from urllib import urlopen
from urllib import URLopener
from urllib import urlretrieve

try:
from distro import linux_distribution
Expand Down Expand Up @@ -320,8 +320,7 @@ def _download_file(url, destination):
final_url = response.geturl()
if final_url != url and is_verbose():
logger.debug('Redirected to %s', final_url)
f = URLopener()
f.retrieve(final_url, destination)
urlretrieve(final_url, destination)


def _http_request(url):
Expand Down