fix some cookstyle warning. add Khosrow as contributor

Author: pdion891

README.md

@@ -4,6 +4,8 @@ cloudstack Cookbook
 Install and configure [Apache Cloudstack](http://cloudstack.apache.org) using [Chef](http://www.chef.io/). A wrapper cookbook is prefered in order to Install Apache CloudStack properly, refer to [cloudstack_wrapper cookbook](https://github.com/cloudops/cookbook_cloudstack_wrapper) for example.
 
 
+Work with Chef 12 only.
+
 Tested on CentOS 7 and Ubuntu 16.04
 
 
@@ -204,7 +206,8 @@ e.g.
 
 License and Authors
 -------------------
-- Author:: Pierre-Luc Dion (<[email protected]>)
+- Author:: Pierre-Luc Dion (<[email protected]>)
+- Author:: Khosrow Moossavi ([email protected])
 
 Some snippets have been taken from: [schubergphilis/cloudstack-cookbook](https://github.com/schubergphilis/cloudstack-cookbook)
 - Author:: Roeland Kuipers (<[email protected]>)  
@@ -213,7 +216,7 @@ Some snippets have been taken from: [schubergphilis/cloudstack-cookbook](https:/
 
 
 ```text
-Copyright:: Copyright (c) 2015 Author's
+Copyright:: Copyright (c) 2018 CloudOps Inc.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

libraries/system_template.rb

@@ -21,7 +21,7 @@
 module Cloudstack
   module SystemTemplate
     # retrieve template ID from database
-    def get_template_id
+    def db_template_id
       # get template ID from database to check path
       Chef::Log.debug 'Retrieve template ID from database'
       template_cmd = "mysql -h #{@current_resource.db_host} --user=#{@current_resource.db_user} --password=#{@current_resource.db_password} --skip-column-names -U cloud -e 'select max(id) from cloud.vm_template where type = \"SYSTEM\" and hypervisor_type = \"#{@current_resource.hypervisor}\" and removed is null'"

providers/api_keys.rb

@@ -40,13 +40,11 @@ def whyrun_supported?
 
 action :create do
   wait_count = 0
-  until cloudstack_api_is_running? || wait_count == 5 do
+  until cloudstack_api_is_running? || wait_count == 5
     cloudstack_api_is_running?
     sleep(5)
     wait_count += 1
-    if wait_count == 1
-      Chef::Log.info 'Waiting CloudStack to start'
-    end
+    Chef::Log.info 'Waiting CloudStack to start' if wait_count == 1
   end
 
   create_admin_apikeys

providers/global_setting.rb

@@ -57,7 +57,6 @@ def load_current_resource
     if @current_resource.admin_apikey.nil?
       Chef::Log.error 'admin_apikey empty, cannot update Global Settings'
     else
-      client = CloudstackRubyClient::Client.new('http://localhost:8080/client/api/', @current_resource.admin_apikey, @current_resource.admin_secretkey, false)
       current_value = load_current_value(@current_resource.name)
       if current_value.nil?
         Chef::Log.error "Global Setting: #{@current_resource.name} not found"

providers/system_template.rb

@@ -58,7 +58,7 @@ def load_current_resource
       cmd.error!
       @current_resource.url(cmd.stdout.chomp)
     end
-    template_id = get_template_id
+    template_id = db_template_id
     Chef::Log.debug "looking for template in #{@current_resource.nfs_path}/template/tmpl/1/#{template_id}"
     if ::File.exist?("#{@current_resource.nfs_path}/template/tmpl/1/#{template_id}/template.properties")
       Chef::Log.debug "template exists in #{@current_resource.nfs_path}/template/tmpl/1/#{template_id}"