chore: Enforce import types (#60)

Author: erezrokah

.eslintrc

@@ -25,6 +25,9 @@
     "require-await": "off",
     "@typescript-eslint/require-await": "error",
     "@typescript-eslint/naming-convention": "error",
+    "import/no-cycle": "error",
+    "import/no-self-import": "error",
+    "@typescript-eslint/consistent-type-imports": "error",
     "import/order": [
       2,
       {

src/grpc/plugin.ts

@@ -1,7 +1,7 @@
 import { pluginV3 } from '@cloudquery/plugin-pb-javascript';
 import grpc = require('@grpc/grpc-js');
 
-import { Plugin } from '../plugin/plugin.js';
+import type { Plugin } from '../plugin/plugin.js';
 import { encodeTables, flattenTables } from '../schema/table.js';
 
 export class MigrateTable extends pluginV3.cloudquery.plugin.v3.Sync.MessageMigrateTable {}

src/grpc/server.ts

@@ -1,8 +1,8 @@
 import { pluginV3, discovery1 } from '@cloudquery/plugin-pb-javascript';
 import grpc = require('@grpc/grpc-js');
-import winston from 'winston';
+import type winston from 'winston';
 
-import { Plugin } from '../plugin/plugin.js';
+import type { Plugin } from '../plugin/plugin.js';
 
 import { DiscoveryServer } from './discovery.js';
 import { PluginServer } from './plugin.js';

src/memdb/delete-stale.ts

@@ -1,4 +1,4 @@
-import { DeleteStale } from '../grpc/plugin.js';
+import type { DeleteStale } from '../grpc/plugin.js';
 
 export type DeleteStaleFunction = (message: DeleteStale) => void;
 

src/memdb/memdb.ts

@@ -1,8 +1,10 @@
 import { default as Ajv } from 'ajv';
 
-import { Plugin, newPlugin, SyncOptions, TableOptions, NewClientFunction } from '../plugin/plugin.js';
+import type { Plugin, SyncOptions, TableOptions, NewClientFunction } from '../plugin/plugin.js';
+import { newPlugin } from '../plugin/plugin.js';
 import { sync } from '../scheduler/scheduler.js';
-import { Table, filterTables } from '../schema/table.js';
+import type { Table } from '../schema/table.js';
+import { filterTables } from '../schema/table.js';
 
 import { createDeleteStale } from './delete-stale.js';
 import { createOverwrite } from './overwrite.js';

src/memdb/overwrite.ts

@@ -1,6 +1,6 @@
-import { StructRowProxy } from '@apache-arrow/esnext-esm';
+import type { StructRowProxy } from '@apache-arrow/esnext-esm';
 
-import { Table } from '../schema/table.js';
+import type { Table } from '../schema/table.js';
 
 //eslint-disable-next-line @typescript-eslint/no-explicit-any
 export type OverwriteFunction = (table: Table, primaryKeys: string[], record: StructRowProxy<any>) => void;

src/memdb/read.ts

@@ -1,4 +1,4 @@
-import { ReadStream, ReadRequest } from '../grpc/plugin.js';
+import type { ReadStream, ReadRequest } from '../grpc/plugin.js';
 import { decodeTable } from '../schema/table.js';
 
 //eslint-disable-next-line @typescript-eslint/no-explicit-any

src/memdb/write.ts

@@ -1,8 +1,9 @@
-import { WriteStream, WriteRequest } from '../grpc/plugin.js';
-import { Table, decodeTable, decodeRecord, getPrimaryKeys } from '../schema/table.js';
+import type { WriteStream, WriteRequest } from '../grpc/plugin.js';
+import type { Table } from '../schema/table.js';
+import { decodeTable, decodeRecord, getPrimaryKeys } from '../schema/table.js';
 
-import { DeleteStaleFunction } from './delete-stale.js';
-import { OverwriteFunction } from './overwrite.js';
+import type { DeleteStaleFunction } from './delete-stale.js';
+import type { OverwriteFunction } from './overwrite.js';
 
 export const createWrite = (
   //eslint-disable-next-line @typescript-eslint/no-explicit-any

src/plugin/plugin.ts

@@ -1,7 +1,7 @@
-import { Logger } from 'winston';
+import type { Logger } from 'winston';
 
-import { SyncStream, ReadStream, WriteStream } from '../grpc/plugin.js';
-import { Table } from '../schema/table.js';
+import type { SyncStream, ReadStream, WriteStream } from '../grpc/plugin.js';
+import type { Table } from '../schema/table.js';
 
 export type BackendOptions = {
   tableName: string;

src/plugin/serve.test.ts

@@ -2,7 +2,8 @@ import test from 'ava';
 
 import { newMemDBPlugin } from '../memdb/memdb.js';
 
-import { createServeCommand, ServeArguments } from './serve.js';
+import type { ServeArguments } from './serve.js';
+import { createServeCommand } from './serve.js';
 
 const serve = createServeCommand(newMemDBPlugin()).exitProcess(false);