Fix NA_Values Testing

Move check_na_values to test_dynamic, changed test assertions to fit

Author: qx-teo

_delphi_utils_python/tests/validator/test_dynamic.py

@@ -105,7 +105,25 @@ def test_0_vs_many(self):
 
         assert len(report.raised_errors) == 1
         assert report.raised_errors[0].check_name == "check_rapid_change_num_rows"
-
+class TestCheckNaVals:
+    params = {
+        "common": {
+            "data_source": "",
+            "span_length": 1,
+            "end_date": "2020-09-02"
+        }
+    }
+    def test_missing(self):
+        validator = DynamicValidator(self.params)
+        report = ValidationReport([])
+        data = {"val": [np.nan] * 14, "geo_id": [0,1] * 7, "time_value": ["2021-09-01"] * 14 }
+        df = pd.DataFrame(data)
+        #df.set_index(range(7), inplace=True)
+        validator.check_na_vals(df, "geo", "signal", report)
+
+        assert len(report.raised_errors) == 2
+        assert report.raised_errors[0].check_name == "check_val_missing (geo_id 0)"
+        assert report.raised_errors[1].check_name == "check_val_missing (geo_id 1)"
 
 class TestCheckAvgValDiffs:
     params = {

_delphi_utils_python/tests/validator/test_static.py

@@ -362,15 +362,6 @@ def test_empty_df(self):
 
         assert len(report.raised_errors) == 0
 
-    def test_missing(self):
-        validator = StaticValidator(self.params)
-        report = ValidationReport([])
-        df = pd.DataFrame([np.nan], columns=["val"])
-        validator.check_bad_val(df, FILENAME, "signal", report)
-
-        assert len(report.raised_errors) == 1
-        assert report.raised_errors[0].check_name == "check_val_missing"
-
     def test_lt_0(self):
         validator = StaticValidator(self.params)
         report = ValidationReport([])